Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Dark scroll bars in templates #43483

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[material-ui][docs] Dark scroll bars in templates #43483

merged 2 commits into from
Aug 27, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Aug 27, 2024 •
edited
Loading

Enable color-scheme so scroll bars look dark in dark mode.

Preview: https://deploy-preview-43483--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/

before after
before after

@aarongarciah aarongarciah added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Aug 27, 2024
@aarongarciah aarongarciah requested a review from zanivan August 27, 2024 20:00
@mui-bot
Copy link

mui-bot commented Aug 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43483--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4a03793

zanivan
zanivan approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aarongarciah aarongarciah enabled auto-merge (squash) August 27, 2024 20:05
@aarongarciah aarongarciah merged commit 9cdc6af into mui:master Aug 27, 2024
22 checks passed
@aarongarciah aarongarciah deleted the template-color-scheme-scrollbar branch August 27, 2024 21:43
@prathik2401 prathik2401 mentioned this pull request Sep 20, 2024
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 21, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Sep 22, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Sep 26, 2024
Merged
This was referenced Oct 3, 2024
Open
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

Assignees
No one assigned
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongarciah @mui-bot @zanivan