[material-ui][Dialog] Fix broken scrolling in full screen mode

[LuseBiswas]

• [] I have followed (at least) the PR section of the contributing guide.
• From my POV I had fix the issue [material-ui][Dialog] Broken scrolling in fullScreen dialogs (v6) #43572. By Improving its css part.
• Changes made in Line Number:- 121, 196, 201. All Changes are done with their respective comments.
• Kindly @DiegoAndai review my code. And give me a possible feedback to fix it.

Fixes #43572
Fixes #43636

[mui-bot]

Netlify deploy preview

https://deploy-preview-43626--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against af7e0e6

[DiegoAndai]

Thanks for tackling this @LuseBiswas! 🚀

Here's my initial review.

As a general comment, it's good to include before and after demos so we know that the PR is actually fixing the issue.

This would be the before demo: https://codesandbox.io/p/sandbox/wizardly-swirles-yw2t4t

And for the after demo, you can clone the before one and make this change in package.json:

-"@mui/icons-material": "latest",
+"@mui/icons-material": "https://pkg.csb.dev/mui/material-ui/commit/285afa8d/@mui/icons-material",
-"@mui/material": "latest",
+"@mui/material": "https://pkg.csb.dev/mui/material-ui/commit/285afa8d/@mui/material"

Where 285afa8d are the first 8 characters of the commit to test (in this case 285afa8). I created the after demo for you this time 😊: https://codesandbox.io/p/sandbox/keen-dewdney-77h2xx?file=%2Fpackage.json%3A5%2C5-6%2C89&workspaceId=836800c1-9711-491c-a89b-3ac24cbd8cd8

[LuseBiswas]

@DiegoAndai
Ok, as I see that the Issue is resolved by implementing it in a Sandbox as you mentioned above.
And I learnt to how write code in less Line of Code.

So can i code get merge with main branch or I have to make some more changes ?

[DiegoAndai]

@LuseBiswas you need to make the changes from my review:

• Update line 121: [material-ui][Dialog] Fix broken scrolling in full screen mode #43626 (comment)
• Remove line 196: [material-ui][Dialog] Fix broken scrolling in full screen mode #43626 (comment)
• Remove line 201: [material-ui][Dialog] Fix broken scrolling in full screen mode #43626 (comment)

[DiegoAndai]

Nice @LuseBiswas. Finally, let's remove the empty lines 196 and 201

[DiegoAndai]

Thanks, @LuseBiswas; now let's wait for the checks to finish 😊. I'll do a final review tomorrow and merge.

[ZeeshanTamboli]

I believe we should add a test case as well to prevent regressions in the future.

[DiegoAndai]

@ZeeshanTamboli, I added a test and confirmed that it fails without the fix. Please review 😊

[LuseBiswas]

@DiegoAndai does it means that my changes in code does not fix the bug. Should I rewrite it ?

[DiegoAndai]

@LuseBiswas no, it confirms that your changes fix the bug 👍🏼 no change needed.

[ZeeshanTamboli]

@DiegoAndai @LuseBiswas I pushed a commit to refactor the test. The PR looks good, so I'll merge it. This also fixes #43636. Thanks for working on it.

[oliviertassinari]

For the future, it should be

Suggested change

	const paperElement = getByTestId('paper');
	const paperElement = screen.getByTestId('paper');

per point 2 of mui/mui-public#173.