[core] Replace more indexOf with includes
#43694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
reviewed
Sep 12, 2024
| @@ -9,7 +9,7 @@ function omit(input, fields) { | |||
| const output = {}; | |||
|
|
|||
| Object.keys(input).forEach((prop) => { | |||
| if (fields.indexOf(prop) === -1) { | |||
| if (!fields.includes(prop)) { | |||
There was a problem hiding this comment.
Just for demonstration purposes, but this is one of those hidden O(nm) complexities that can be reduced down to O(n)+O(m):
function omit(input, fields) {
const output = {};
const fieldSet = new Set(fields)
Object.keys(input).forEach((prop) => {
if (!fieldSet.has(prop)) {
output[prop] = input[prop];
}
});
return output;
}Not to be changed unless proven to be a real performance improvement though, it adds an extra allocation. This comment is just for information only.
aarongarciah
approved these changes
Sep 12, 2024
This commit is a follow-up of #42883 (review). Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
aarongarciah
force-pushed
the
refactor/includes
branch
2 times, most recently
from
7d4a7bd
to
609fa7f
Compare
Netlify deploy previewhttps://deploy-preview-43694--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
| @@ -496,7 +496,7 @@ const attachPropsTable = ( | |||
|
|
|||
| const requiredProp = | |||
| prop.required || | |||
| /\.isRequired/.test(prop.type.raw) || | |||
| prop.type.raw.includes('.isRequired') || | |||
There was a problem hiding this comment.
This line is failing when raw is not a string. I pushed this fix:
- prop.type.raw.includes('.isRequired') ||
+ prop.type.raw?.includes('.isRequired') ||
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #42883 (review) and #42883 (review).
/cc @aarongarciah @Janpot