Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][mui-system] Simplify version prerelease export #43699

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

DiegoAndai
Copy link
Member

Follow up on #43190 (comment).

Replace preReleaseLabel and preReleaseNumber exports in favor of prerelease export, as this is simpler and we can save the bundle size.

Not considering this a breaking change as these consts are only available on prerelease versions

@DiegoAndai DiegoAndai added package: system Specific to @mui/system package: material-ui Specific to @mui/material labels Sep 10, 2024
@DiegoAndai DiegoAndai self-assigned this Sep 10, 2024
@mui-bot
Copy link

mui-bot commented Sep 10, 2024

Netlify deploy preview

https://deploy-preview-43699--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 54c125a

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this 👍

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

To consider at which point this should be added to the other packages, etc. If we consider that today we don't need this, and tomorrow we might, then the same reasoning applies to Base UI, Pigment CSS, etc.

@DiegoAndai DiegoAndai merged commit 494c10c into mui:master Sep 11, 2024
21 checks passed
@DiegoAndai DiegoAndai deleted the improve-version-export branch September 11, 2024 12:20
@oliviertassinari
Copy link
Member

Waiting for upvotes issue created mui/base-ui#599, maybe one day it will make sense there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants