Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Optimize regression tests #43889

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 26, 2024

Results:

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Sep 26, 2024
@mui-bot
Copy link

mui-bot commented Sep 26, 2024

Netlify deploy preview

https://deploy-preview-43889--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 632de3d

@Janpot Janpot marked this pull request as ready for review September 26, 2024 08:59
@Janpot Janpot requested a review from a team September 26, 2024 08:59
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be documented somewhere?

Make it possible to scope a single test in running test:regressions. Just add route = [''] at https://github.com/Janpot/material-ui/blob/632de3d7de97eadb3cc225aca5a3e3a4ba25fb10/test/regressions/index.test.js#L51

@Janpot
Copy link
Member Author

Janpot commented Sep 30, 2024

Should this be documented somewhere?

I think we can document it if we add specific API for it. The "feature" is more a side-effect of the changes I did to optimize them.

@Janpot Janpot merged commit 65efa9f into mui:master Sep 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants