Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Forbid calling Error without new #43963

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 2, 2024

Noticed in #43904 that the error minification macro checks for this, but it would be better served by an eslint rule, so that more of our code base is covered.

Also removing an unused ignore line.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Oct 2, 2024
@Janpot Janpot requested a review from a team October 2, 2024 08:13
@mui-bot
Copy link

mui-bot commented Oct 2, 2024

Netlify deploy preview

https://deploy-preview-43963--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 13298a0

@Janpot Janpot marked this pull request as ready for review October 2, 2024 08:30
.eslintrc.js Outdated Show resolved Hide resolved
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just one nit.

Janpot and others added 2 commits October 2, 2024 13:22
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot enabled auto-merge (squash) October 2, 2024 15:43
@Janpot Janpot merged commit ccffda9 into mui:master Oct 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants