Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lab][Timeline] Fix types for React 19 #44043

Merged
merged 1 commit into from
Oct 8, 2024
+3 −3
Merged

[lab][Timeline] Fix types for React 19 #44043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mui-lab/src/Timeline/Timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ const useUtilityClasses = (ownerState: OwnerState) => {
return composeClasses(slots, getTimelineUtilityClass, classes);
};

const TimelineRoot = styled('ul' as const, {
name: 'MuiTimeline' as const,
Comment on lines -24 to -25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these since they look unnecessary.

const TimelineRoot = styled('ul', {
name: 'MuiTimeline',
slot: 'Root',
overridesResolver: (props, styles) => {
const { ownerState } = props;
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-lab/src/Timeline/Timeline.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Theme } from '@mui/material/styles';
import { SxProps } from '@mui/system';
import { TimelineClasses } from './timelineClasses';

export interface TimelineProps extends StandardProps<React.HTMLAttributes<HTMLUListElement>> {
export interface TimelineProps extends StandardProps<React.ComponentProps<'ul'>> {
/**
* The position where the TimelineContent should appear relative to the time axis.
* @default 'right'
Expand Down
Loading