Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove dead code #44056

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[test] Remove dead code #44056

merged 1 commit into from
Oct 10, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 9, 2024 •
edited
Loading

We don't use ReactDOM.render anymore anywhere.

@mui-bot
Copy link

mui-bot commented Oct 9, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44056--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a5797a3

@Janpot Janpot added the test label Oct 9, 2024
@Janpot Janpot marked this pull request as ready for review October 9, 2024 14:23
@Janpot Janpot requested a review from a team October 10, 2024 08:39
@Janpot Janpot merged commit 8d13ccd into mui:master Oct 10, 2024
19 of 20 checks passed
@michaldudak
Copy link
Member

Shouldn't we, though? https://app.circleci.com/insights/github/mui/material-ui/workflows/react-17-cron/overview

@Janpot Janpot deleted the remove-dead-code branch October 10, 2024 16:00
@Janpot
Copy link
Member Author

Janpot commented Oct 10, 2024 •
edited
Loading

Shouldn't we, though?

Yes, if we want these to run again. Taking a quick look at them, things we'll have to fix additionally:

  • 132 faiing unit tests, mostly because we use testing library renderHook.
  • regression tests failing because depedencies using 'react/jsx-runtime'.

Not fully convinced it makes sense to allocate a lot of time to this.

@michaldudak
Copy link
Member

Then let's disable the tests so we don't waste credits for no reason.

@Janpot Janpot mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @mui-bot @michaldudak @mnajdova