Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Fix typo in typography theme set up for templates #44338

Merged
merged 9 commits into from
Nov 11, 2024
Merged

[docs][material-ui] Fix typo in typography theme set up for templates #44338

merged 9 commits into from
Nov 11, 2024

Conversation

navedqb
Copy link
Contributor

@navedqb navedqb commented Nov 7, 2024 •
edited
Loading

Fixes #44324

@navedqb
fix typo
824d670 
Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
@navedqb
Merge pull request #2 from navedqb/fix--44324
da91864 
fix: typo in mui typography theme set up
@navedqb navedqb changed the title Fix 44324 fix: typo in mui typography theme set up Nov 7, 2024
@mui-bot
Copy link

mui-bot commented Nov 7, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44338--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f1180a7

@ZeeshanTamboli ZeeshanTamboli changed the title fix: typo in mui typography theme set up [docs][material-ui] Fix typo in typography theme set up for templates Nov 7, 2024
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Nov 7, 2024
ZeeshanTamboli
ZeeshanTamboli reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navedqb Can you fix the CI by updating the TypeScript demo using pnpm docs:typescript:formatted and format using Prettier (pnpm prettier)?

@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Nov 9, 2024
@ZeeshanTamboli
Copy link
Member

Merging with the latest master branch could fix the CI.

ZeeshanTamboli
ZeeshanTamboli approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ZeeshanTamboli ZeeshanTamboli merged commit 9fbc6f9 into mui:master Nov 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@zanivan zanivan Awaiting requested review from zanivan

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] MUI free template has a typo in Typography's theme set up
3 participants
@navedqb @mui-bot @ZeeshanTamboli