Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Replace 'Experimental APIs - Toolpad' with 'Toolpad (Beta)' #44388

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

prakhargupta1
Copy link
Member

One title was missed in #43796

@prakhargupta1 prakhargupta1 added the docs Improvements or additions to the documentation label Nov 12, 2024
@mui-bot
Copy link

mui-bot commented Nov 12, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4c43113

@prakhargupta1 prakhargupta1 merged commit 075a785 into mui:master Nov 12, 2024
22 of 23 checks passed
@prakhargupta1 prakhargupta1 deleted the toolpad branch November 12, 2024 10:51
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 17, 2024

As far as I know, this was correct, this feature is currently being experimented with in Toolpad Core and it's a table stake feature for any toast component to be taken seriously: https://www.notion.so/mui-org/core-Snackbar-component-c5f2d92ea5b74f52a65a7ff28a3a5c26. For example, Radix Primitives gives an example of how to build it, and Shadcn UI has it built natively. I wanted to have this in Material UI forever: #18098.

Can we revert this?

cc @colmtuite @aarongarciah depending on how far we want to go with the toast, I guess it will either be a Base UI or MUI feature, depending on where we want to draw the line.

@oliviertassinari oliviertassinari added the component: snackbar This is the name of the generic UI component, not the React module! label Nov 17, 2024
@bharatkashyap
Copy link
Member

I'm facing a strange error when trying to revert this:

Screenshot 2024-11-18 at 11 02 12 AM

Not sure if this is related to permissions

@prakhargupta1
Copy link
Member Author

I'm facing a strange error when trying to revert this:

I am getting the same error.

@bharatkashyap
Copy link
Member

I'm facing a strange error when trying to revert this:

I am getting the same error.

Perhaps you can create a new PR that reverts this commit, we can merge that

@prakhargupta1
Copy link
Member Author

Perhaps you can create a new PR that reverts this commit, we can merge that

#44454

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 19, 2024

I'm facing a strange error when trying to revert this:

@bharatkashyap Permissions related. Most of the MUI org repositories prevent the creation of new branches on the repository. They have to be created on a fork. This restriction exists so that branches don't add noise, keeping this easy to use:

SCR-20241119-capl

Renovates adds a lot of noise, but it's only because we are slow in merging them, we use to merge them fast enough not to have more than 10 opens.

oliviertassinari pushed a commit that referenced this pull request Nov 19, 2024
Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
@colmtuite
Copy link
Contributor

@oliviertassinari Base UI will release Toast in Q1, and then Material UI will wrap it for v8.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 19, 2024

@colmtuite Toast should be in Base UI, agree. Linked this to mui/base-ui#220.

I was more thinking about: would Base UI supports the imperative API or only MUI? For example, Radix Primitives doesn't support it, proof: https://www.radix-ui.com/primitives/docs/components/toast#imperative-api, maybe it's for the best, unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation Toolpad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants