[utils] skip deep clone React element #44400
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-44400--material-ui.netlify.app/ @material-ui/core: parsed: -0.10% 😍, gzip: -0.05% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Skipping React elements in deepClone and deepMerge makes sense to me 👍🏼
Because this is a shared util, let's wait to see if @mui/x or @mui/toolpad have any objections. If there are none in a couple of days, we can go ahead and merge this.
Does that sound right?
|
We are not using either of those (unless they are used under the hood in some API we use) so for me it's good |
|
Thanks for the info @flaviendelangle @bharatkashyap |
DiegoAndai
approved these changes
Nov 15, 2024
|
@siriwatknp can you merge this fix into mui v5? There's the same issue. |
jukkatupamaki
added a commit
to jukkatupamaki/material-ui
that referenced
this pull request
Nov 21, 2024
1 task
jukkatupamaki
added a commit
to jukkatupamaki/material-ui
that referenced
this pull request
Nov 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #44278
Root cause
Next.js 15 with Turbopack has a different signature for React element which cause the
@mui/utils/deepmergeto recursively deepclone React element. More details on #44278Fix
I think it does not make sense anyway for the deepmerge function to deepClone React elements.
So I added a check to deepmerge directly to avoid deepClone React elements.
Tested with https://github.com/nphmuller/mui-next-15_0_2_issue, this PR fixes the issue.