-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Do not enforce the presence of ownerState.className
in describeConformance
#44479
[test] Do not enforce the presence of ownerState.className
in describeConformance
#44479
Conversation
Netlify deploy previewhttps://deploy-preview-44479--material-ui.netlify.app/ Bundle size report |
This changes the meaning of this test entirely. The purpose of it is to test if the |
We should update the name of the test then, IMHO it does not describe what you are saying. |
Yup, 2 different tests are a good option as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I added the 2nd test 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
A good compromise to cater for both the @mui/material
as well as the transitional approach on mui-x@v8
👌
In
@mui/x-date-pickers
and@mui/x-date-pickers-pro
, we are updating all ourownerState
(both the one used inslotProps
and the one used instyled()
orstyleOverrides
to be a small object shared across all the slots of the library.The idea behind this change is that, from a user point of view, it is unclear which part of this UI resolves those slots since the component are very large. So the props used for the
ownerState
is hardly predictable and does not contain the same information from one slot to another, often missing key information of the current state of the picker.I encountered a small problem because
describeConformance
usesownerState.className
which is no longer present in our components for some tests. Do you see a problem hardcoding a value instead?