Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icons] Change icon source URL and add overrides #45020

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[icons] Change icon source URL and add overrides #45020

wants to merge 8 commits into from
+2,372 −26

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 14, 2025 •
edited
Loading

The added files caused by updating the icons source url to be the latest one (based on Material icons site).

@mui-bot
Copy link

mui-bot commented Jan 14, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45020--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 75e141e

@siriwatknp siriwatknp added the package: icons Specific to @mui/icons label Jan 14, 2025
@siriwatknp siriwatknp changed the title [icons] Remove blacklist icons and rerun the script [icons] Change icon source and add overrides Jan 14, 2025
@siriwatknp siriwatknp changed the title [icons] Change icon source and add overrides [icons] Change icon source url and add overrides Jan 14, 2025
@siriwatknp siriwatknp changed the title [icons] Change icon source url and add overrides [icons] Change icon source URL and add overrides Jan 14, 2025
@mnajdova
Copy link
Member

Can you check also #44970?

@siriwatknp
Copy link
Member Author

Can you check also #44970?

I checked both Material Icons and Symbol, no reference that I can use as an override. I think this should be fixed from Material icons.

image

@siriwatknp siriwatknp requested a review from mnajdova January 17, 2025 08:34
michaldudak
michaldudak reviewed Jan 23, 2025
View reviewed changes
packages/mui-icons-material/scripts/download.mjs
// official icon is not rounded: https://fonts.google.com/icons?selected=Material+Icons+Round:apps:&icon.query=apps&icon.size=24&icon.color=%23e8eaed&icon.set=Material+Icons&icon.style=Rounded
// fixes https://github.com/mui/material-ui/issues/41064
'apps_rounded',
'<svg width="24" height="24" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><path d="M6 20C5.45 20 4.97917 19.8042 4.5875 19.4125C4.19583 19.0208 4 18.55 4 18C4 17.45 4.19583 16.9792 4.5875 16.5875C4.97917 16.1958 5.45 16 6 16C6.55 16 7.02083 16.1958 7.4125 16.5875C7.80417 16.9792 8 17.45 8 18C8 18.55 7.80417 19.0208 7.4125 19.4125C7.02083 19.8042 6.55 20 6 20ZM12 20C11.45 20 10.9792 19.8042 10.5875 19.4125C10.1958 19.0208 10 18.55 10 18C10 17.45 10.1958 16.9792 10.5875 16.5875C10.9792 16.1958 11.45 16 12 16C12.55 16 13.0208 16.1958 13.4125 16.5875C13.8042 16.9792 14 17.45 14 18C14 18.55 13.8042 19.0208 13.4125 19.4125C13.0208 19.8042 12.55 20 12 20ZM18 20C17.45 20 16.9792 19.8042 16.5875 19.4125C16.1958 19.0208 16 18.55 16 18C16 17.45 16.1958 16.9792 16.5875 16.5875C16.9792 16.1958 17.45 16 18 16C18.55 16 19.0208 16.1958 19.4125 16.5875C19.8042 16.9792 20 17.45 20 18C20 18.55 19.8042 19.0208 19.4125 19.4125C19.0208 19.8042 18.55 20 18 20ZM6 14C5.45 14 4.97917 13.8042 4.5875 13.4125C4.19583 13.0208 4 12.55 4 12C4 11.45 4.19583 10.9792 4.5875 10.5875C4.97917 10.1958 5.45 10 6 10C6.55 10 7.02083 10.1958 7.4125 10.5875C7.80417 10.9792 8 11.45 8 12C8 12.55 7.80417 13.0208 7.4125 13.4125C7.02083 13.8042 6.55 14 6 14ZM12 14C11.45 14 10.9792 13.8042 10.5875 13.4125C10.1958 13.0208 10 12.55 10 12C10 11.45 10.1958 10.9792 10.5875 10.5875C10.9792 10.1958 11.45 10 12 10C12.55 10 13.0208 10.1958 13.4125 10.5875C13.8042 10.9792 14 11.45 14 12C14 12.55 13.8042 13.0208 13.4125 13.4125C13.0208 13.8042 12.55 14 12 14ZM18 14C17.45 14 16.9792 13.8042 16.5875 13.4125C16.1958 13.0208 16 12.55 16 12C16 11.45 16.1958 10.9792 16.5875 10.5875C16.9792 10.1958 17.45 10 18 10C18.55 10 19.0208 10.1958 19.4125 10.5875C19.8042 10.9792 20 11.45 20 12C20 12.55 19.8042 13.0208 19.4125 13.4125C19.0208 13.8042 18.55 14 18 14ZM6 8C5.45 8 4.97917 7.80417 4.5875 7.4125C4.19583 7.02083 4 6.55 4 6C4 5.45 4.19583 4.97917 4.5875 4.5875C4.97917 4.19583 5.45 4 6 4C6.55 4 7.02083 4.19583 7.4125 4.5875C7.80417 4.97917 8 5.45 8 6C8 6.55 7.80417 7.02083 7.4125 7.4125C7.02083 7.80417 6.55 8 6 8ZM12 8C11.45 8 10.9792 7.80417 10.5875 7.4125C10.1958 7.02083 10 6.55 10 6C10 5.45 10.1958 4.97917 10.5875 4.5875C10.9792 4.19583 11.45 4 12 4C12.55 4 13.0208 4.19583 13.4125 4.5875C13.8042 4.97917 14 5.45 14 6C14 6.55 13.8042 7.02083 13.4125 7.4125C13.0208 7.80417 12.55 8 12 8ZM18 8C17.45 8 16.9792 7.80417 16.5875 7.4125C16.1958 7.02083 16 6.55 16 6C16 5.45 16.1958 4.97917 16.5875 4.5875C16.9792 4.19583 17.45 4 18 4C18.55 4 19.0208 4.19583 19.4125 4.5875C19.8042 4.97917 20 5.45 20 6C20 6.55 19.8042 7.02083 19.4125 7.4125C19.0208 7.80417 18.55 8 18 8Z"/></svg>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have these overrides as files in a specific subdirectory so they can be actually viewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak left review comments

@mnajdova mnajdova Awaiting requested review from mnajdova

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
4 participants
@siriwatknp @mui-bot @mnajdova @michaldudak