[Rating] Fix Rating returns NaN when using user event #45054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NooBat
force-pushed
the
fix/rating-test-with-user-event
branch
from
cdf633e to
b7804d9
Compare
zannager
added
the
component: rating
siriwatknp
reviewed
Jan 23, 2025
Comment on lines
+410
to
+415
| if (Number.isNaN(newHover)) { | ||
| // Workaround for test scenario using userEvent since jsdom defaults getBoundingClientRect to 0 | ||
| // Fix https://github.com/mui/material-ui/issues/38828 | ||
| newHover = -1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Does it make more sense to return if Number.isNaN(newHover) is true?
if (Number.isNaN(newHover)) {
return;
}There was a problem hiding this comment.
Then move the setFocusVisible(false) up before the condition so it always run.
ZeeshanTamboli
changed the title
Netlify deploy previewhttps://deploy-preview-45054--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38828