-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][Table] Fixed scrollbar such that it start from the first row of the table in Sticky Header table #45056
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the unexpected file changes before we review this PR.
Here unexpected means the files not related to table component |
Yes correct. Remove files not related to the Table. |
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
Signed-off-by: MachaVivek <130957321+MachaVivek@users.noreply.github.com>
@@ -93,6 +93,21 @@ export default function StickyHeadTable() { | |||
|
|||
return ( | |||
<Paper sx={{ width: '100%', overflow: 'hidden' }}> | |||
<Table stickyHeader aria-label="sticky table"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rendering two tables? Two table headers are shown: https://deploy-preview-45056--material-ui.netlify.app/material-ui/react-table/#sticky-header.
Since there is no reply, I am closing this PR. |
Table before the changes
Table after the changes
Files where the code is changed
material-ui/docs/data/material/components/table/StickyHeadTable.tsx
closes #34416