[code-infra] Remove rsc-builder #45079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45079--material-ui.netlify.app/ Bundle size report |
JCQuintas
reviewed
Jan 21, 2025
| statement.expression.value === 'use client', | ||
| ); | ||
| hasUseServerDirective = hasDirective(node, 'use server'); | ||
| hasUseClientDirective = hasDirective(node, 'use client'); | ||
| }, | ||
| CallExpression(node) { | ||
| if ( | ||
| !hasUseClientDirective && |
There was a problem hiding this comment.
Shouldn't this check for !hasUseServerDirective as well? 🤔
There was a problem hiding this comment.
No, the marked APIs are not allowed in server components. i.e. the plugin should flag when 'use client' is missing while client APIs are used in the file. The hasUseServerDirective is only there to prevent adding a 'use client' when there already is a 'use server' while autofixing. This is a contradiction that the programmer must resolve manually.
JCQuintas
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're doing this with eslint now. The rule is auto-fixable. Added some types to the eslint plugin as well and cleaned it up, functionally no difference.