Use a single div for Paper #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a conversation with Hai Nguyen (@hai-cea), he confirmed that the only reason for creating an inner div was preserving the two shadows. Since it's possible in CSS to apply two or more shadows to a single element, such nested structure is in my opinion redundant. The order of shadows matters: shadows for an element are applied top to bottom (first one goes on top), we had to put the child's shadows first.
|
Looks great @pomerantsev 👍 I didn't know this was possible! :) |
zannager
added
the
component: Paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a conversation with Hai Nguyen (@hai-cea), he confirmed that the
only reason for creating an inner div was preserving the two shadows.
Since it's possible in CSS to apply two or more shadows to a single
element, such nested structure is in my opinion redundant.
The order of shadows matters: shadows for an element are applied
top to bottom (first one goes on top), we had to put the child's
shadows first.