Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Friendly Dropdown #846

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Conversation

chrismcv
Copy link
Contributor

This PR should sort #51.

It also includes #789 (which I'm using for "Select-Field".

@chrismcv
Copy link
Contributor Author

FYI - this doesn't include value/valueLink support yet... I'm going to do this shortly.

@chrismcv
Copy link
Contributor Author

I've added value/valueLink support. Note that props.selectedIndex will take precedence if both are set.

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

@chrismcv On the docs page, the Custom Child input is behaving a little strange. looks like you have it on a disabled input, but it's still clickable slightly above the hint text.

Also, what is the difference between SelectField and DropdownMenu? As a user, would I just opt to use SelectField all the time?

Thank you so much for this!

@chrismcv
Copy link
Contributor Author

Sorry about that... carelessness!

Should be sorted now....

DropdownMenu is for use when embedding it in Toolbars etc - as the height styling is fairly different.

Select Field should be preferred for any "form" type usage.

Also - the changes to menu apply keyboard friendliness to Menu/NestedMenu/Left Nav as well (assuming they have focus)... I didn't make LeftNav focusable by default, but this might be worth considering as well.

Finally - I patched up jshint.js and package.json to fix #845, which has been causing my grief as well.

@hai-cea
Copy link
Member

hai-cea commented Jun 15, 2015

Found a display glitch on the last SelectField example. To recreate:

  1. Click and select "Every Night"
  2. Click the SelectField to open the menu again. This time, just click away without selecting anything.

fireshot capture - material ui - http___localhost_3000_ _components_text-fields

Also, SelectField with a default value does not highlight the menu item on first open.

Could you also squash these commits down to 1 please?

Thanks!

@chrismcv chrismcv force-pushed the keyboard-friendly-dropdown branch 3 times, most recently from ef5c34e to e96d313 Compare June 15, 2015 20:14
@chrismcv
Copy link
Contributor Author

Should be everything now :)

@hai-cea
Copy link
Member

hai-cea commented Jun 16, 2015

@chrismcv Were you able to recreate the problems I mentioned earlier? - #846 (comment)

I'm still seeing it on my end.

@chrismcv
Copy link
Contributor Author

just checking now, thought i'd sorted last night...

@chrismcv
Copy link
Contributor Author

must have missed it when i squashed.... new commit there now...

@hai-cea
Copy link
Member

hai-cea commented Jun 16, 2015

Thanks @chrismcv !

@chrismcv chrismcv deleted the keyboard-friendly-dropdown branch February 1, 2016 21:12
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* Update to the @date-io v1

* Fix luxon & moment issues

* Update to date-io v1.0.1
@zannager zannager added the component: menu This is the name of the generic UI component, not the React module! label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants