-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[codemod] Add missing
preset-safe for the data-grid (#15709)
Signed-off-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
- Loading branch information
Showing
6 changed files
with
184 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/x-codemod/src/v8.0.0/data-grid/preset-safe/actual.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // @ts-nocheck | ||
| import * as React from 'react'; | ||
| import { DataGridPremium } from '@mui/x-data-grid-premium'; | ||
|
|
||
| // prettier-ignore | ||
| <React.Fragment> | ||
| <DataGridPremium | ||
| experimentalFeatures={{ | ||
| warnIfFocusStateIsNotSynced: true, | ||
| ariaV8: true, | ||
| }} | ||
| /> | ||
| <DataGridPremium | ||
| experimentalFeatures={{ | ||
| ariaV8: true, | ||
| }} | ||
| /> | ||
| <DataGridPremium {...props} /> | ||
| </React.Fragment>; |
14 changes: 14 additions & 0 deletions
14
packages/x-codemod/src/v8.0.0/data-grid/preset-safe/expected.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // @ts-nocheck | ||
| import * as React from 'react'; | ||
| import { DataGridPremium } from '@mui/x-data-grid-premium'; | ||
|
|
||
| // prettier-ignore | ||
| <React.Fragment> | ||
| <DataGridPremium | ||
| experimentalFeatures={{ | ||
| warnIfFocusStateIsNotSynced: true, | ||
| }} | ||
| /> | ||
| <DataGridPremium /> | ||
| <DataGridPremium {...props} /> | ||
| </React.Fragment>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import removeExperimentalFeatures from '../remove-stabilized-experimentalFeatures'; | ||
|
|
||
| import { JsCodeShiftAPI, JsCodeShiftFileInfo } from '../../../types'; | ||
|
|
||
| export default function transformer(file: JsCodeShiftFileInfo, api: JsCodeShiftAPI, options: any) { | ||
| file.source = removeExperimentalFeatures(file, api, options); | ||
|
|
||
| return file.source; | ||
| } |
41 changes: 41 additions & 0 deletions
41
packages/x-codemod/src/v8.0.0/data-grid/preset-safe/preset-safe.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import path from 'path'; | ||
| import { expect } from 'chai'; | ||
| import jscodeshift from 'jscodeshift'; | ||
| import transform from './index'; | ||
| import readFile from '../../../util/readFile'; | ||
|
|
||
| function read(fileName) { | ||
| return readFile(path.join(__dirname, fileName)); | ||
| } | ||
|
|
||
| describe('v8.0.0/data-grid', () => { | ||
| describe('preset-safe', () => { | ||
| it('transforms code as needed', () => { | ||
| const actual = transform( | ||
| { | ||
| source: read('./actual.spec.tsx'), | ||
| path: require.resolve('./actual.spec.tsx'), | ||
| }, | ||
| { jscodeshift: jscodeshift.withParser('tsx') }, | ||
| {}, | ||
| ); | ||
|
|
||
| const expected = read('./expected.spec.tsx'); | ||
| expect(actual).to.equal(expected, 'The transformed version should be correct'); | ||
| }); | ||
|
|
||
| it('should be idempotent for expression', () => { | ||
| const actual = transform( | ||
| { | ||
| source: read('./expected.spec.tsx'), | ||
| path: require.resolve('./expected.spec.tsx'), | ||
| }, | ||
| { jscodeshift: jscodeshift.withParser('tsx') }, | ||
| {}, | ||
| ); | ||
|
|
||
| const expected = read('./expected.spec.tsx'); | ||
| expect(actual).to.equal(expected, 'The transformed version should be correct'); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| import transformTreeView from '../tree-view/preset-safe'; | ||
| import transformPickers from '../pickers/preset-safe'; | ||
| import transformCharts from '../charts/preset-safe'; | ||
| import transformDataGrid from '../data-grid/preset-safe'; | ||
| import { JsCodeShiftAPI, JsCodeShiftFileInfo } from '../../types'; | ||
|
|
||
| export default function transformer(file: JsCodeShiftFileInfo, api: JsCodeShiftAPI, options: any) { | ||
| file.source = transformTreeView(file, api, options); | ||
| file.source = transformPickers(file, api, options); | ||
| file.source = transformCharts(file, api, options); | ||
| file.source = transformDataGrid(file, api, options); | ||
|
|
||
| return file.source; | ||
| } |