Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts][ESM] @mui/x-charts does not work with jest #11568

Closed
Notalifeform opened this issue Jan 3, 2024 · 32 comments · Fixed by #13608
Closed

[charts][ESM] @mui/x-charts does not work with jest #11568

Notalifeform opened this issue Jan 3, 2024 · 32 comments · Fixed by #13608
Labels
component: charts This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it support: commercial Support request from paid users test

Comments

@Notalifeform
Copy link

Notalifeform commented Jan 3, 2024

The problem in depth 🔍

Link to example: https://github.com/rocsys/mui-x-charts-jest-issue-minimal-reproduction/

Steps:

  1. run yarn test --watchAll=false

jest will fail with

 FAIL  src/App.test.tsx
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /Users/rbakker/work/rocsys/code/t/test-mui-chart/node_modules/d3-scale/src/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){export {
                                                                                      ^^^^^^

    SyntaxError: Unexpected token 'export'

    > 1 | import { ChartContainer, BarPlot } from '@mui/x-charts';
        | ^
      2 |
      3 | const uData = [4000, 3000, 2000, 2780, 1890, 2390, 3490];
      4 | const xLabels = [

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1728:14)
      at Object.<anonymous> (node_modules/@mui/x-charts/context/CartesianContextProvider.js:11:16)
      at Object.<anonymous> (node_modules/@mui/x-charts/context/index.js:18:33)
      at Object.<anonymous> (node_modules/@mui/x-charts/index.js:24:16)
      at Object.<anonymous> (src/TinyBarChart.tsx:1:1)
      at Object.<anonymous> (src/App.tsx:4:1)
      at Object.<anonymous> (src/App.test.tsx:3:1)
      at TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (node_modules/@jest/core/build/runJest.js:404:19)
      at _run10000 (node_modules/@jest/core/build/cli/index.js:320:7)
      at runCLI (node_modules/@jest/core/build/cli/index.js:173:3)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.677 s

I attempted to transpile the mui/x-chart module, but it does not seem to work?

https://github.com/rocsys/mui-x-charts-jest-issue-minimal-reproduction/tree/feature/attempt-to-transpile

our project uses without any issue:

   "@mui/icons-material": "^5.14.18",
    "@mui/material": "^5.14.18",
    "@mui/x-data-grid-pro": "^6.18.1",
    "@mui/x-date-pickers-pro": "^6.18.1",
    "@mui/x-license-pro": "^6.10.2",

but jest breaks when adding

    "@mui/x-charts": "^6.18.4",

Your environment 🌎

npx @mui/envinfo
    System:
    OS: macOS 14.0
  Binaries:
    Node: 18.16.1 - ~/.nvm/versions/node/v18.16.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.16.1/bin/yarn
    npm: 9.7.2 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 120.0.6099.129
    Edge: Not Found
    Safari: 17.0
  npmPackages:
    @emotion/react: ^11.11.3 => 11.11.3 
    @emotion/styled: ^11.11.0 => 11.11.0 
    @mui/base:  5.0.0-beta.29 
    @mui/core-downloads-tracker:  5.15.2 
    @mui/material: ^5.15.2 => 5.15.2 
    @mui/private-theming:  5.15.2 
    @mui/styled-engine:  5.15.2 
    @mui/styles: ^5.15.2 => 5.15.2 
    @mui/system:  5.15.2 
    @mui/types:  7.2.11 
    @mui/utils:  5.15.2 
    @mui/x-charts: ^6.18.4 => 6.18.4 
    @types/react: ^18.0.0 => 18.2.46 
    react: ^18.2.0 => 18.2.0 
    react-dom: ^18.2.0 => 18.2.0 
    typescript: ^4.4.2 => 4.9.5 

Contextn

Related issue: jestjs/jest#9430

Search keywords: x-charts jest
Order ID: 70120

@Notalifeform Notalifeform added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Jan 3, 2024
@zannager zannager added the component: charts This is the name of the generic UI component, not the React module! label Jan 4, 2024
@michelengelen michelengelen changed the title mui-x/charts does not work with jest [charts] @mui/x-charts does not work with jest Jan 4, 2024
@michelengelen
Copy link
Member

michelengelen commented Jan 4, 2024

@alexfauquette it seems d3-scale uses modules in its build files. Any idea how we can support that?

https://github.com/d3/d3-scale/blob/d6904a4bde09e16005e0ad8ca3e25b10ce54fa0d/package.json#L21

@michelengelen michelengelen added the external dependency Blocked by external dependency, we can’t do anything about it label Jan 4, 2024
@alexfauquette
Copy link
Member

Seems similar to #9826 (comment)

I also found other issues on this topic, but did not manage to fix the reproduction example with them

@michelengelen
Copy link
Member

Hi @Notalifeform could you try using this fix: d3/d3-interpolate#96 (comment) please?

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 4, 2024
@Notalifeform
Copy link
Author

Hi @Notalifeform could you try using this fix: d3/d3-interpolate#96 (comment) please?

Hi @michelengelen ,

Thanks for getting back to me.

I did try to transpile the module as in this brach, but it did not help:

https://github.com/rocsys/mui-x-charts-jest-issue-minimal-reproduction/pull/1/files

moving the config to package.json did not help either:

https://github.com/rocsys/mui-x-charts-jest-issue-minimal-reproduction/pull/2/files

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Jan 4, 2024
@michelengelen
Copy link
Member

Hey @Notalifeform ... Thanks for testing that. It's a shame it wasn't that easy of a fix.
I am pretty sure @alexfauquette mentioned that he is working on a more profound fix. Right Alex?

@alexfauquette
Copy link
Member

I'm adding test on the charts We have similar (not exactly the same) issue to add test on our side on charts. I assume solving #11551 would help

@michelengelen
Copy link
Member

@alexfauquette I did assign this to you to keep track of it. Could you comment here when the addition of tests provides a solution for this? Thanks! 🙇🏼

@alexfauquette alexfauquette removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 9, 2024
@leonid1976
Copy link

leonid1976 commented Jan 25, 2024

How I fixed the issue:

  1. Editing node_modules/@mui/x-charts/package.json with the following changes (patch)
   "exports": {
    ".": {
      "require": "./index.js",
      "types": "./index.d.ts",
      "import": "./esm/index.js",
      "default": "./esm/index.js"
    },
    "./*": {
      "require": "./*",
      "types": "./*/index.d.ts",
      "import": "./esm/*/index.js",
      "default": "./esm/*/index.js"
    }
  },
  1. in jest.config.js
        moduleNameMapper: {
        '^d3-shape$': '<rootDir>/node_modules/d3-shape/dist/d3-shape.min.js',
        '^d3-path$': '<rootDir>/node_modules/d3-path/dist/d3-path.min.js',
        '^d3-scale$': '<rootDir>/node_modules/d3-scale/dist/d3-scale.min.js',
        '^d3-array$': '<rootDir>/node_modules/d3-array/dist/d3-array.min.js',
        '^d3-interpolate$': '<rootDir>/node_modules/d3-interpolate/dist/d3-interpolate.min.js',
        '^d3-color$': '<rootDir>/node_modules/d3-color/dist/d3-color.min.js',
        '^d3-format$': '<rootDir>/node_modules/d3-format/dist/d3-format.min.js',
        '^d3-time$': '<rootDir>/node_modules/d3-time/dist/d3-time.min.js',
        '^d3-time-format$': '<rootDir>/node_modules/d3-time-format/dist/d3-time-format.min.js',
      },
  1. mock window.matchMedia.addEventListener.
    Edit: likely no longer needed since https://github.com/mui/mui-x/pull/13398/files#diff-e9c5e5094fda00c2fdbf2123dc0444616d70f23655a02a3fc87634425a37de6aR14

@oliviertassinari oliviertassinari changed the title [charts] @mui/x-charts does not work with jest [charts][ESM] @mui/x-charts does not work with jest Jan 29, 2024
tklein1801 added a commit to BudgetBuddyDE/Webapp that referenced this issue Jan 30, 2024
@GazitLior1
Copy link

GazitLior1 commented Feb 19, 2024

I had the same issue and adding this mock:

jest.mock("@mui/x-charts", () => ({ 
  BarChart: jest.fn().mockImplementation(({ children }) => children)
}));

to the tests solved it
(from https://stackoverflow.com/questions/77202795/mui-x-charts-error-syntaxerror-unexpected-token-export)

@cstephens-cni
Copy link

This in my jest config got me going again, but obviously it's alot

transformIgnorePatterns: [
    '/node_modules/(?!@mui/x-charts|@mui/material|@babel/runtime|d3-(color|format|interpolate|scale|shape|time|time-format|path|array)|internmap)',
  ],

@alexfauquette alexfauquette removed their assignment Apr 9, 2024
@Hosoo8861

This comment was marked as resolved.

@cstephens-cni
Copy link

This in my jest config got me going again, but obviously it's alot

transformIgnorePatterns: [
    '/node_modules/(?!@mui/x-charts|@mui/material|@babel/runtime|d3-(color|format|interpolate|scale|shape|time|time-format|path|array)|internmap)',
  ],

I just updated to v7 charts had to add a few more.

add "robust-predicates|delaunator"

@TVDharma
Copy link

TVDharma commented Jun 4, 2024

I had the same issue and adding this mock:

jest.mock("@mui/x-charts", () => ({ 
  Piechart: jest.fn().mockImplementation(({ children }) => children)
}));

to the tests solved it (from https://stackoverflow.com/questions/77202795/mui-x-charts-error-syntaxerror-unexpected-token-export)

Dear Team and @alexfauquette

The above solution resolved the export token issue encountered while running Jest test cases for my project. However, one component in my project extensively uses the PieChart. When attempting to run Jest for that component, I encountered a few more issues: Could you please review and guide this matter?

Warning React.jsx type is invalid --expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

and also

console.warn
{
componentStack: '\n' +

  • at div\n' +
  • (path like ../a/b.js)\n' +
  • at div\n' +
  • at div\n' +
  • (path like ../a/b.js)\n' +
  • at div\n' +
  • at div\n' +
  • (path like ../a/b.js)\n' +
    -----similary----- and it stopped in one file

console.error
the above error occurred in the

component:

at div
at metircvalue (path)
at div
at div
at forward Ref (path)
at div
at forward Ref (path)
at div
at forward Ref (path)
at div
at forward Ref (path)
at div
at fontcl
at div
at forward Ref (path)
at div
at forward Ref (path)
--------stopeed at one file-------
React fill try to recreate this component tree from scratch using this error boundary you provided, e.

@TVDharma
Copy link

TVDharma commented Jun 5, 2024

I had the same issue and adding this mock:

jest.mock("@mui/x-charts", () => ({ 
  Piechart: jest.fn().mockImplementation(({ children }) => children)
}));

to the tests solved it (from https://stackoverflow.com/questions/77202795/mui-x-charts-error-syntaxerror-unexpected-token-export)

Dear Team and @alexfauquette

The above solution resolved the export token issue encountered while running Jest test cases for my project. However, one component in my project extensively uses the PieChart. When attempting to run Jest for that component, I encountered a few more issues: Could you please review and guide this matter?

Warning React.jsx type is invalid --expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

and also

console.warn { componentStack: '\n' +

  • at div\n' +
  • (path like ../a/b.js)\n' +
  • at div\n' +
  • at div\n' +
  • (path like ../a/b.js)\n' +
  • at div\n' +
  • at div\n' +
  • (path like ../a/b.js)\n' +
    -----similary----- and it stopped in one file

console.error the above error occurred in the

component:
at div at metircvalue (path) at div at div at forward Ref (path) at div at forward Ref (path) at div at forward Ref (path) at div at forward Ref (path) at div at fontcl at div at forward Ref (path) at div at forward Ref (path) --------stopeed at one file------- React fill try to recreate this component tree from scratch using this error boundary you provided, e.

Dear @cstephens-cni @Notalifeform and @oliviertassinari and @alexfauquette and @michelengelen, Could anyone in this thread please reply to help me with this? I am stuck in the middle. Thanks.

@alexfauquette
Copy link
Member

@TVDharma Without a minimal reproduction example, it's hard to say why the workaround does not work for you

joaopflausino added a commit to Vicente-MD/investment_project that referenced this issue Jun 18, 2024
Config files changes to work with d3-scale (mui/mui-x#11568)
@si-saaref
Copy link

si-saaref commented Jul 10, 2024


    Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    Chart-example\node_modules\@babel\runtime\helpers\esm\extends.js:10
    export { _extends as default };
    ^^^^^^

    SyntaxError: Unexpected token 'export'

      10 | import {chartsGridClasses, BarChartProps} from '@mui/x-charts';
      11 | import {axisClasses} from '@mui/x-charts/ChartsAxis';
    > 12 |
         | ^
      13 | export default function CustomChart({
      14 |   titleChart,
      15 |   type,

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.<anonymous> (node_modules/@mui/x-charts/esm/BarChart/BarChart.js:11:57)
      at Object.<anonymous> (node_modules/@mui/x-charts/esm/BarChart/index.js:5:14)

The d3 bug was resolved, but I encounter another bug..
Would you mind to help me to figure out how to solve this?


Just found out the resolve method.. following @cstephens-cni
I added some configuration in my next jest app

async function jestConfig() {
  const nextJestConfig = await createJestConfig(customJestConfig)();
  nextJestConfig.transformIgnorePatterns = [
    // '/node_modules/(?!@mui/x-charts|@mui/material|@babel/runtime|d3-scale)',
    '/node_modules/(?!@mui/x-charts|@mui/material|@babel/runtime|d3-(color|format|interpolate|scale|shape|time|time-format|path|array|delaunay)|internmap|delaunator|robust-predicates)',
  ];
  return nextJestConfig;
}

@onkartme
Copy link

Still facing the issue with BarChart.

`SyntaxError: Unexpected token 'export'

  1 | import { Box,Typography } from "@mui/material";
> 2 | import { BarChart } from "@mui/x-charts/BarChart";
    | ^`

here is my jest config

module.exports = { testEnvironment: "jsdom", setupFilesAfterEnv: ["<rootDir>/setupTests.ts"], transform: { "^.+\\.(js|jsx|ts|tsx)$": "babel-jest", }, moduleNameMapper: { "^@/(.*)$": "<rootDir>/src/$1", }, transformIgnorePatterns: [ "/node_modules/(?!@mui/x-charts|@mui/material|@babel/runtime)", ], };

@konrazem
Copy link

We have the same issue with ChartsAxis, as there is an export in ESM module

..  \node_modules\@mui\x-charts\esm\ChartsAxis\index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){export * from './ChartsAxis';
                                                                                                                                            ^^^^^^

    SyntaxError: Unexpected token 'export'

      2 |
      3 | import { Box } from '@mui/material';
    > 4 | import { axisClasses } from '@mui/x-charts/ChartsAxis';
        | ^
      5 | import { LineChart } from '@mui/x-charts/LineChart';
      6 |
      7 | import { ChartLegend } from '@uniteam/iamu-framework';

None of the given solutions did solve it 😔

@alexfauquette
Copy link
Member

alexfauquette commented Jul 16, 2024

@konrazem @onkartme Could you test if by using the following package version in your package.json the problem get solved?

"@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts",
"@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts-vendor",

Those are preview of #13608

Edit I edited this message to update the commit used. The original ones were broken due to a regression in the PR. Please do not consider the feedback following this message

@konrazem
Copy link

konrazem commented Jul 16, 2024

@alexfauquette thank you for taking care of this issue. Unfortunatelly it didn't help.

The only solution that is working right now for as is to add this conditions to our jest.config.js to moduleNameMapper

moduleNameMapper: {
      //////////////////////////////////////
      /// X-CHARTS
      //////////////////////////////////////
      '@mui/x-charts': '<rootDir>/node_modules/@mui/x-charts/index.js',

      //////////////////////////////////////
      /// D3 BASED ON X-CHARTS
      //////////////////////////////////////
      '^d3-array$': '<rootDir>/node_modules/d3-array/dist/d3-array.min.js',
      '^d3-color$': '<rootDir>/node_modules/d3-color/dist/d3-color.min.js',
      '^d3-delaunay$':
        '<rootDir>/node_modules/d3-delaunay/dist/d3-delaunay.min.js',
      '^d3-format$': '<rootDir>/node_modules/d3-format/dist/d3-format.min.js',
      '^d3-interpolate$':
        '<rootDir>/node_modules/d3-interpolate/dist/d3-interpolate.min.js',
      '^d3-path$': '<rootDir>/node_modules/d3-path/dist/d3-path.min.js',
      '^d3-scale$': '<rootDir>/node_modules/d3-scale/dist/d3-scale.min.js',
      '^d3-shape$': '<rootDir>/node_modules/d3-shape/dist/d3-shape.min.js',
      '^d3-time$': '<rootDir>/node_modules/d3-time/dist/d3-time.min.js',
      '^d3-time-format$':
        '<rootDir>/node_modules/d3-time-format/dist/d3-time-format.min.js',
      //////////////////////////////////////
    },

@alexfauquette
Copy link
Member

@konrazem could you share a reproduction of your issue? Because your issue is probably different than the one in this issue, because using the PR commit solves the intial reproduction

@onkartme
Copy link

"@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/b7ffe8e1/@mui/x-charts",
"@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/b7ffe8e1/@mui/x-charts-vendor",

hey @alexfauquette

unfortunately this didn't solve the issue. The issue still there. :(

@alexfauquette
Copy link
Member

alexfauquette commented Jul 17, 2024

My bad, I double-checked and it seems the fix is broken. My apologies giving you broken links.

Could you try again with the last working one

    "@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts",
    "@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts-vendor",

This one is fixing the reproduction in the initial issue

image

@tonyhallett

This comment was marked as resolved.

@konrazem
Copy link

I think it is strongly related to this issue.

As I mentioned, we were able to fix our tests with this solution

@alexfauquette thank you for taking care of this issue. Unfortunatelly it didn't help.

The only solution that is working right now for as is to add this conditions to our jest.config.js to moduleNameMapper

moduleNameMapper: {
      //////////////////////////////////////
      /// X-CHARTS
      //////////////////////////////////////
      '@mui/x-charts': '<rootDir>/node_modules/@mui/x-charts/index.js',

      //////////////////////////////////////
      /// D3 BASED ON X-CHARTS
      //////////////////////////////////////
      '^d3-array$': '<rootDir>/node_modules/d3-array/dist/d3-array.min.js',
      '^d3-color$': '<rootDir>/node_modules/d3-color/dist/d3-color.min.js',
      '^d3-delaunay$':
        '<rootDir>/node_modules/d3-delaunay/dist/d3-delaunay.min.js',
      '^d3-format$': '<rootDir>/node_modules/d3-format/dist/d3-format.min.js',
      '^d3-interpolate$':
        '<rootDir>/node_modules/d3-interpolate/dist/d3-interpolate.min.js',
      '^d3-path$': '<rootDir>/node_modules/d3-path/dist/d3-path.min.js',
      '^d3-scale$': '<rootDir>/node_modules/d3-scale/dist/d3-scale.min.js',
      '^d3-shape$': '<rootDir>/node_modules/d3-shape/dist/d3-shape.min.js',
      '^d3-time$': '<rootDir>/node_modules/d3-time/dist/d3-time.min.js',
      '^d3-time-format$':
        '<rootDir>/node_modules/d3-time-format/dist/d3-time-format.min.js',
      //////////////////////////////////////
    },

@sterlingdcs-damian
Copy link

@https://github.com/alexfauquette using

 "@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/b7ffe8e1/@mui/x-charts",
    "@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/b7ffe8e1/@mui/x-charts-vendor",
   

doesnt fix it for me ,. i get

Test suite failed to run

 Cannot find module '@mui/x-charts-vendor/d3-scale' from 'node_modules/@mui/x-charts/context/CartesianProvider/computeValue.js'

 Require stack:
   node_modules/@mui/x-charts/context/CartesianProvider/computeValue.js
   node_modules/@mui/x-charts/context/CartesianProvider/index.js
   node_modules/@mui/x-charts/BarChart/BarPlot.js
   node_modules/@mui/x-charts/BarChart/BarChart.js
   node_modules/@mui/x-charts/BarChart/index.js
   src/app-project/features/cost-plan-lifecycle/presentation/components/cost-summary/CostSummaryBarChart.tsx

@alexfauquette
Copy link
Member

@sterlingdcs-damian You copied the one with b7ffe8e1 commit which as explained here are broken (due to missing .npmignore file)

Could you try with either

// The initial working fix

"@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts",
"@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/0a35124a/@mui/x-charts-vendor",

// The last step of the PR

"@mui/x-charts": "https://pkg.csb.dev/mui/mui-x/commit/fca1af4e/@mui/x-charts",
"@mui/x-charts-vendor": "https://pkg.csb.dev/mui/mui-x/commit/fca1af4e/@mui/x-charts-vendor",

@LukasTy
Copy link
Member

LukasTy commented Jul 24, 2024

This is where mui/material-ui#42984 would provide a bit nicer UX/DX for users in such cases with the ability to reference packages by GH PR number. 🤔
cc @oliviertassinari @alexfauquette

@alexfauquette
Copy link
Member

For users, yes but not for developers. Being able to retry the build of previous commits helped me to narrow down which commit introduced the regression

@LukasTy
Copy link
Member

LukasTy commented Jul 24, 2024

For users, yes but not for developers. Being able to retry the build of previous commits helped me to narrow down which commit introduced the regression

You can use both identifiers. 😉

Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@Notalifeform: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@alexfauquette
Copy link
Member

The fix will be available in the next release at the end of the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it support: commercial Support request from paid users test
Projects
None yet
Development

Successfully merging a pull request may close this issue.