Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Follow-up on docs generation #1826

Open
2 of 12 tasks
oliviertassinari opened this issue Jun 3, 2021 · 3 comments
Open
2 of 12 tasks

[docs] Follow-up on docs generation #1826

oliviertassinari opened this issue Jun 3, 2021 · 3 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 3, 2021

#1529 is a major step forward toward exhaustive documentation of the API. These are opportunities I have seen that we could tackle next:

copy.mp4
  • 6. The apiRef blocks pattern can be used in many other parts: density, edit row, csv export, and in the core too.

  • 7. We have a JSON docs generator in the core repository for React components (not interfaces). We should be able to use it for DataGrid, XGrid, GridToolbarContainer, GridToolbarExport, etc.

  • 8. Once we have this JSON generated. We can move to the next step, read it to render the API page. We have a page component to read it in the core repository, we should be able to use it too.

  • 9. The documentation of the interface in the core repository needs to be improved. A couple of examples: 1, 2, 3. It's not great, having no documentation for the headless component, it does not work. We have started to build a tool to solve this pain in this repository. We need the same one in the core repository. For instance:

  • 10. We have two opportunities to better link GridExportCsvOptions that we don't leverage:

Capture d’écran 2021-07-25 à 16 08 42

Capture d’écran 2021-07-25 à 16 08 44

https://deploy-preview-2102--material-ui-x.netlify.app/api/data-grid/grid-api/

  • 11. In some cases, it might feel overkill to create a dedicated page for small interfaces. Or maybe we should have the two but when it's simple enough, also embed in the docs page, as @m4theushw did for the apiRef. applyFilter is listed twice https://material-ui.com/components/data-grid/filtering/#apiref

  • 12. We miss more details about the apiRef, we could:

    • remove this URL /components/data-grid/events/
    • move content of the event page inside a /components/data-grid/advanced/ URL, under a h2 (not a h1 as currently)
    • add a description about how apiRef works (h2)
    • link the sub section of apiRef to the relevant features, e.g. filtering

    For instance, it could look like this:

    # Data Grid - Advanced
    
    ## apiRef
    
    Introduction, how to use it.
    
    ### Features
    
    - Filtering: https://master--material-ui-x.netlify.app/components/data-grid/filtering/#apiref
    - Export
    - etc.
    
    ## Events
    
    Introduction, the naming convention
    
    ### Props
    
    ### subscribeEvent
    
    apiRef
    
    ### Catalog of events

    Feedback on it here: [docs] Follow-up on docs generation #1826 (comment)

cc @m4theushw

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 3, 2021
@dtassone
Copy link
Member

dtassone commented Jun 4, 2021

As mention before I think we can create an advanced page, with events and other more advanced concept in it, like apiRef...

@oliviertassinari

This comment has been minimized.

@dtassone
Copy link
Member

dtassone commented Jun 4, 2021

Yes something like that seems great. It would allow more advanced users to find deeper use cases of the grid in one place and to understand in more depth the concepts.
So we could add links to the advanced page in different pages such as rows streaming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants