Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTimePicker] showToolbar default value is true, should be false #4455

Closed
2 tasks done
timonla opened this issue Dec 3, 2021 · 3 comments · Fixed by #4451
Closed
2 tasks done

[DateTimePicker] showToolbar default value is true, should be false #4455

timonla opened this issue Dec 3, 2021 · 3 comments · Fixed by #4451
Labels
bug 🐛 Something doesn't work component: DateTimePicker The React component.

Comments

@timonla
Copy link

timonla commented Dec 3, 2021

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

The default value for showToolbar is true.

Expected behavior 🤔

The default value should be false like the documentation suggests.

Steps to reproduce 🕹

  1. Look at the documentation of any DateTimePicker component (https://mui.com/api/desktop-date-time-picker/)
  2. It says that showToolbar is false by default
  3. See actual default value here: https://codesandbox.io/s/priceless-haslett-vg1bi?file=/src/Demo.tsx

Context 🔦

This is an issue with DateTimePicker, MobileDateTimePicker and DesktopDateTimePicker. It seems to work as specified in documentation for DatePicker and TimePicker components.

Your environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@timonla timonla added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 3, 2021
@mbrookes mbrookes added component: DateTimePicker The React component. bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 4, 2021
@mbrookes mbrookes changed the title DateTimePicker showToolbar default value is opposite what documentation suggests [DateTimePicker] showToolbar default value is opposite what documentation suggests Dec 4, 2021
@mbrookes mbrookes changed the title [DateTimePicker] showToolbar default value is opposite what documentation suggests [DateTimePicker] showToolbar default value is true, should be false Dec 4, 2021
@alisasanib
Copy link

Hi! May I work on it?

@narekmal
Copy link

Hi! Can I take this issue?

@flaviendelangle
Copy link
Member

Sorry for the delay, I applioed your pull request on the new package in #4451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: DateTimePicker The React component.
Projects
None yet
5 participants