-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix default props behavior on all pickers #4451
Merged
flaviendelangle
merged 8 commits into
mui:master
from
flaviendelangle:refacto-responsive-date-range-picker
Apr 12, 2022
Merged
[core] Fix default props behavior on all pickers #4451
flaviendelangle
merged 8 commits into
mui:master
from
flaviendelangle:refacto-responsive-date-range-picker
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
core
Infrastructure work going on behind the scenes
component: pickers
This is the name of the generic UI component, not the React module!
component: DateRangePicker
The React component.
labels
Apr 11, 2022
These are the results for the performance tests:
|
flaviendelangle
changed the title
[core] Refacto responsive behavior on DateRangePicker
[core] Fix default props behavior on all pickers
Apr 11, 2022
flaviendelangle
added
bug 🐛
Something doesn't work
and removed
core
Infrastructure work going on behind the scenes
labels
Apr 11, 2022
2 tasks
alexfauquette
approved these changes
Apr 12, 2022
2 tasks
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: DateRangePicker
The React component.
component: pickers
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
showToolbar
default value onDateTimePicker
Fixes #4455
It is simply a migration of mui/material-ui#30258
The default value was
yet
but the doc was saying otherwiseApply same code structure for the
DateRangePicker
as on the other componentsAll others responsive picker components (
TimePicker
/DatePicker
andDateTimePicker
) are just tiny wrappers that calls there mobile and desktop components.But for the range picker, we had duplication of a large interface + duplication of most code between
DateRangePicker
,MobileDateRangePicker
andDesktopDateRangePicker
.Fix the props priority (component props > theme props > default props)
Fixes #4454
We currently do something like:
So
someProp
is never undefined when passed touseThemeProps
.I changed it to:
Others
I also replaced the ternaries by
if
in the other components.I don't like the usage of ternaries for long expressions.