[DataGridPro] Make default filter items have stable references in header filters #10338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10338--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
romgrk
reviewed
Sep 15, 2023
| @@ -53,6 +55,7 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => { | |||
| hasOtherElementInTabSequence || columnHeaderFilterTabIndexState !== null, | |||
| }); | |||
| const headerFiltersRef = React.useRef<HTMLDivElement>(null); | |||
| const filterItemsRef = React.useRef<Map<GridStateColDef['field'], GridFilterItem>>(new Map()); | |||
There was a problem hiding this comment.
Maybe just a Objcet.create(null) object here?
There was a problem hiding this comment.
Sure, done in aac5faf
romgrk
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10325
The bug surfaced after #9712, the reason is the same as in #8119, i.e. till a valid filter item is defined for a column, a new default filter item is being generated on every render which is causing the useEffect in the GridFilterItemValue to be called unnecessarily hence removing the first typed character from the header filter.
Test: I didn't manage to reproduce the issue, probably it's not re-rendering that often in test env 🤔