Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datagrid] Fix typing of GridActionsCellItem #10344

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Sep 15, 2023

Fixes #4654

Fix typing, add component.

#4654 (comment)

@romgrk romgrk added component: data grid This is the name of the generic UI component, not the React module! typescript labels Sep 15, 2023
@mui-bot
Copy link

mui-bot commented Sep 15, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10344--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -200.9 -13.4 -18.9 -85.46 70.83
Sort 100k rows ms 634 1,279.5 1,232.3 1,103.16 237.541
Select 100k rows ms 613.5 812.6 681.6 696.66 65.542
Deselect 100k rows ms 125.4 205.8 183.1 178.34 29.502

Generated by 🚫 dangerJS against f7593e6

@romgrk romgrk enabled auto-merge (squash) September 17, 2023 12:43
@romgrk romgrk merged commit 33838fb into mui:master Sep 19, 2023
18 checks passed
@romgrk romgrk deleted the fix-actions-cell-prop branch September 19, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing of custom component to render in GridActionsCellItem
4 participants