[core] Use the classnames helper #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
dtassone
approved these changes
Jul 27, 2020
dtassone
added a commit
that referenced
this pull request
Jul 27, 2020
* Release v0.1.62 (#95) * v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace * fix resize issue (#96) * Bump eslint-config-airbnb-typescript from 8.0.2 to 9.0.0 (#112) * Pagination refactoring (#100) * implemented server pagination * rename pagination options, doc, prettier * fix lint * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * change casing value in featureMode and remove apiref check * added missing dep in useEffect * fix broken suggestion code * fix doc comments * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * Fix FeatureMode enum and remove useCallback in demo * fix import order * added namespace to function call to remove import * remove useCallback and add react. to mdx code * add concurrency in server pagination demo * fix feature mode export Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [core] Use the classnames helper (#105) * [core] Batch small changes (#104) * [docs] Improve the JSDoc (#106) * rename events and add onHover event (#103) * rename events and added onHover event * rename events and added onHover event * fix onPageChange rename and merge * Js doc improvements Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * added hover stories * small fix and cleanup * revert rename, back to onRowSelected * refactor hover and click handlers * refactor cellParams * prettier Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * v0.1.63 * v0.1.64 * prettier lerna.json due to lerna Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
dtassone
added a commit
that referenced
this pull request
Jul 28, 2020
* Release v0.1.62 (#95) * v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace * fix resize issue (#96) * Bump eslint-config-airbnb-typescript from 8.0.2 to 9.0.0 (#112) * Pagination refactoring (#100) * implemented server pagination * rename pagination options, doc, prettier * fix lint * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * change casing value in featureMode and remove apiref check * added missing dep in useEffect * fix broken suggestion code * fix doc comments * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * Fix FeatureMode enum and remove useCallback in demo * fix import order * added namespace to function call to remove import * remove useCallback and add react. to mdx code * add concurrency in server pagination demo * fix feature mode export Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [core] Use the classnames helper (#105) * [core] Batch small changes (#104) * [docs] Improve the JSDoc (#106) * rename events and add onHover event (#103) * rename events and added onHover event * rename events and added onHover event * fix onPageChange rename and merge * Js doc improvements Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * added hover stories * small fix and cleanup * revert rename, back to onRowSelected * refactor hover and click handlers * refactor cellParams * prettier Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * v0.1.63 * v0.1.64 * prettier lerna.json due to lerna Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
dtassone
added a commit
that referenced
this pull request
Jul 28, 2020
* Release v0.1.62 (#95) * v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace * fix resize issue (#96) * Bump eslint-config-airbnb-typescript from 8.0.2 to 9.0.0 (#112) * Pagination refactoring (#100) * implemented server pagination * rename pagination options, doc, prettier * fix lint * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * change casing value in featureMode and remove apiref check * added missing dep in useEffect * fix broken suggestion code * fix doc comments * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * Fix FeatureMode enum and remove useCallback in demo * fix import order * added namespace to function call to remove import * remove useCallback and add react. to mdx code * add concurrency in server pagination demo * fix feature mode export Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [core] Use the classnames helper (#105) * [core] Batch small changes (#104) * [docs] Improve the JSDoc (#106) * rename events and add onHover event (#103) * rename events and added onHover event * rename events and added onHover event * fix onPageChange rename and merge * Js doc improvements Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * added hover stories * small fix and cleanup * revert rename, back to onRowSelected * refactor hover and click handlers * refactor cellParams * prettier Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [test] Add yarn deduplicate step (#107) * [DataGrid] Set default logLevel to warn (#117) * override default logLevel to warn * rerun CI Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [test] Lint JSON (#108) * Merging release back to master (#120) * v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace * v0.1.63 * v0.1.64 * prettier lerna.json due to lerna * fix cellClassRule type, fix keyboard timeout, small refactoring (#123) * fix cellClassRule type, fix keyboard timeout, small refactoring * prettier fix * add cancel RAF for focus if new event coming * added keyboard doc (#125) * added keyboard doc * Apply suggestions from code review Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> * [DataGrid] Fix selection issue (#126) * fix selection issue * fix selection issue test Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the helper everywhere it's interesting. Next step will be to rename it clsx and bundle the dependency.
#6