-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Improve Russian (ru-RU) locale #11210
[l10n] Improve Russian (ru-RU) locale #11210
Conversation
dastan-akhmetov-scity
commented
Nov 27, 2023
•
edited
Loading
edited
- I have followed (at least) the PR section of the contributing guide.
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-11210--material-ui-x.netlify.app/ |
942538f
to
b2e5dfc
Compare
b2e5dfc
to
4f316ac
Compare
@cherniavskii do you know if this change makes sense? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@cherniavskii we could probably move on with this one |
Hey @dastan-akhmetov-scity Could you rebase with the latest |
4f316ac
to
672c261
Compare
I have tried to fix the PR. Using this code to check accuracy: var cardinalRules = new Intl.PluralRules("ru-RU")
Array.from(new Array(50)).map((x, index) => cardinalRules.select(index)) The logic is still not right IMHO, but it feels like a good enough step forward for this PR. What I would explore more of:
|
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>