-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React #11280
Bump React #11280
Conversation
Deploy preview: https://deploy-preview-11280--material-ui-x.netlify.app/ |
cb51079
to
093aa9b
Compare
093aa9b
to
b1f37ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DefinitelyTyped/DefinitelyTyped#67170 removed the placeholder
property from HTMLAttributes
.
This caused an error with the UseFieldResponse
type because it is trying to pick the removed placeholder
property.
Pick<React.HTMLAttributes<HTMLInputElement>, 'autoCorrect' | 'inputMode' | 'placeholder'> & { |
TS2344: Type "autoCorrect" | "inputMode" | "placeholder" does not satisfy the constraint keyof HTMLAttributes<HTMLInputElement>
Type "placeholder" is not assignable to type keyof HTMLAttributes<HTMLInputElement>
This is currently breaking my company's ability to update to the latest |
Thank you for noting it @heath-freenome. Are you not excluding |
@LukasTy It is occurring during our attempts to publish the esm version of our library using |
@heath-freenome Could you double-check if replacing your latest pickers package version with - "@mui/x-date-pickers": "^6.18.4",
+ "@mui/x-date-pickers": "https://pkg.csb.dev/mui/mui-x/commit/f0c6585a/@mui/x-date-pickers", |
Yes! It does!! Please let me know when you've released this |
The fix has been merged into the
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
That fix also works, thanks! |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
8ba4628
to
ca4e1ad
Compare
This PR contains the following updates:
^18.2.46
->^18.2.47
^18.2.17
->^18.2.18
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.