Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump React #11280

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Bump React #11280

merged 1 commit into from
Jan 11, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 3, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) ^18.2.46 -> ^18.2.47 age adoption passing confidence
@types/react-dom (source) ^18.2.17 -> ^18.2.18 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Dec 3, 2023
@mui-bot
Copy link

mui-bot commented Dec 3, 2023

Deploy preview: https://deploy-preview-11280--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ca4e1ad

@renovate renovate bot changed the title Bump @types/react to ^18.2.41 Bump @types/react to ^18.2.42 Dec 4, 2023
@renovate renovate bot changed the title Bump @types/react to ^18.2.42 Bump @types/react to ^18.2.43 Dec 9, 2023
Copy link
Contributor

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DefinitelyTyped/DefinitelyTyped#67170 removed the placeholder property from HTMLAttributes.

This caused an error with the UseFieldResponse type because it is trying to pick the removed placeholder property.

Pick<React.HTMLAttributes<HTMLInputElement>, 'autoCorrect' | 'inputMode' | 'placeholder'> & {

TS2344: Type "autoCorrect" | "inputMode" | "placeholder" does not satisfy the constraint keyof HTMLAttributes<HTMLInputElement>
Type "placeholder" is not assignable to type keyof HTMLAttributes<HTMLInputElement>

@heath-freenome
Copy link

DefinitelyTyped/DefinitelyTyped#67170 removed the placeholder property from HTMLAttributes.

This caused an error with the UseFieldResponse type because it is trying to pick the removed placeholder property.

Pick<React.HTMLAttributes<HTMLInputElement>, 'autoCorrect' | 'inputMode' | 'placeholder'> & {

TS2344: Type "autoCorrect" | "inputMode" | "placeholder" does not satisfy the constraint keyof HTMLAttributes<HTMLInputElement>
Type "placeholder" is not assignable to type keyof HTMLAttributes<HTMLInputElement>

This is currently breaking my company's ability to update to the latest @types/react as well. I'd love it if this gets fixed in the source code here

@LukasTy LukasTy self-assigned this Dec 12, 2023
@LukasTy
Copy link
Member

LukasTy commented Dec 12, 2023

This PR is still blocked by #11303, because we need this fix to fix the missing shallow-update type option. 🙈

@LukasTy
Copy link
Member

LukasTy commented Dec 12, 2023

This is currently breaking my company's ability to update to the latest @types/react as well. I'd love it if this gets fixed in the source code here

Thank you for noting it @heath-freenome.
We are currently somewhat blocked from releasing a fix, as mentioned in the above comment. 🙈

Are you not excluding node_modules dependencies from TS type checking? 🤔
AFAIK, it's pretty common to exclude any dependencies to improve performance and avoid doing type checking twice (we do it on our end before releasing already). 🤔

@heath-freenome
Copy link

heath-freenome commented Dec 12, 2023

@LukasTy It is occurring during our attempts to publish the esm version of our library using tsc and even adding node_modules to the exclude does not fix it

@LukasTy
Copy link
Member

LukasTy commented Dec 12, 2023

It is occurring during our attempts to publish the esm version of our library using tsc and even adding node_modules to the exclude does not fix it

@heath-freenome Could you double-check if replacing your latest pickers package version with https://pkg.csb.dev/mui/mui-x/commit/f0c6585a/@mui/x-date-pickers (build of this PR) solves the problem? 🤔

- "@mui/x-date-pickers": "^6.18.4",
+ "@mui/x-date-pickers": "https://pkg.csb.dev/mui/mui-x/commit/f0c6585a/@mui/x-date-pickers",

@heath-freenome
Copy link

https://pkg.csb.dev/mui/mui-x/commit/f0c6585a/@mui/x-date-pickers

Yes! It does!! Please let me know when you've released this

@LukasTy
Copy link
Member

LukasTy commented Dec 13, 2023

Yes! It does!! Please let me know when you've released this

The fix has been merged into the next and master branches and will be included with the next release, which will happen on Thursday or Friday. 😉
If you have the time, you could double-check if the latest master build works for you.

https://pkg.csb.dev/mui/mui-x/commit/f0e5702e/@mui/x-date-pickers

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 13, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@heath-freenome
Copy link

Yes! It does!! Please let me know when you've released this

The fix has been merged into the next and master branches and will be included with the next release, which will happen on Thursday or Friday. 😉 If you have the time, you could double-check if the latest master build works for you.

https://pkg.csb.dev/mui/mui-x/commit/f0e5702e/@mui/x-date-pickers

That fix also works, thanks!

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 15, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@LukasTy LukasTy mentioned this pull request Jan 11, 2024
@renovate renovate bot changed the title Bump @types/react to ^18.2.43 Bump React Jan 11, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 11, 2024
@LukasTy LukasTy merged commit 892e05c into next Jan 11, 2024
17 checks passed
@LukasTy LukasTy deleted the renovate/react branch January 11, 2024 13:58
@oliviertassinari oliviertassinari added external dependency Blocked by external dependency, we can’t do anything about it and removed blocked labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies external dependency Blocked by external dependency, we can’t do anything about it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants