Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Use readonly array result for getTreeDataPath #11743

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Jan 18, 2024

We do not try to modify the array after receiving it, so let's accept an immutable array. This is still compatible with existing usage of getTreeDataPath.

@mui-bot
Copy link

mui-bot commented Jan 18, 2024

Deploy preview: https://deploy-preview-11743--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d8f6370

@pcorpet pcorpet force-pushed the readonly-tree-data-path branch from 982d960 to 9308a68 Compare January 18, 2024 22:49
@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Jan 19, 2024
Copy link

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@MBilalShafi MBilalShafi changed the base branch from next to master March 21, 2024 02:27
@pcorpet pcorpet force-pushed the readonly-tree-data-path branch from 9308a68 to 857d7f2 Compare April 26, 2024 22:12
@pcorpet pcorpet changed the base branch from master to next April 26, 2024 22:13
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 26, 2024
@oliviertassinari oliviertassinari added the plan: Pro Impact at least one Pro user label May 24, 2024
@oliviertassinari oliviertassinari changed the title [DataGridPro] Use readonly array result for getTreeDataPath. [data grid] Use readonly array result for getTreeDataPath May 24, 2024
@zannager zannager requested a review from cherniavskii May 27, 2024 14:30
We do not try to modify the array after receiving it, so let's accept an immutable array.
This is still compatible with existing usage of getTreeDataPath.
@pcorpet pcorpet force-pushed the readonly-tree-data-path branch from 857d7f2 to 7cc32b1 Compare July 18, 2024 21:58
@pcorpet pcorpet changed the base branch from next to master July 18, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants