Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[support-infra] Add release announcement to GitHub workflows #11867

Merged
merged 11 commits into from
Apr 3, 2024
Merged

[support-infra] Add release announcement to GitHub workflows #11867

merged 11 commits into from
Apr 3, 2024

Conversation

michelengelen
Copy link
Member

@michelengelen michelengelen commented Jan 30, 2024 •
edited
Loading

This action will send a message to the #announcements channel on our discord server when there is a new release (events: release:published and release:prereleased).

For this to work we need to add a separator line into the changelog. This will be a comment string sitting just before the detailed changes.

...

<!--/ DO_NOT_REMOVE /-->

### Data Grid

...

This string needs to stay in order for the script to know where the highlights end.
The reason why we are doing this is that Discord does not allow messages to be above 2000 characters.

The message posted will look like this (tested with the v7-beta-0 Changelog):
Screenshot 2024-01-31 at 14 59 43

@michelengelen michelengelen added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Jan 30, 2024
@michelengelen michelengelen self-assigned this Jan 30, 2024
@mui-bot
Copy link

mui-bot commented Jan 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-11867--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against aca244c

joserodolfofreitas
joserodolfofreitas reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @michelengelen! Thank you for pushing forward on this front!

joserodolfofreitas
joserodolfofreitas reviewed Jan 31, 2024
View reviewed changes
.github/workflows/discord-release-announcement.yaml
name: Send message to discord
steps:
- name: parse and send message
uses: michelengelen/discord-message-action@02af30a15955ecf718049bc33b0efabf6f626e0b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, maybe we should review the action itself? Since it's the most essential part of the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes ... please go ahead. It's my private one, so nothing to hide there! :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the link to it for reference: https://github.com/michelengelen/discord-message-action

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it - seems good. I think we can move forward and add this to the release workflow

@oliviertassinari oliviertassinari changed the title [code-infra] adds release announcement to github workflows [code-infra] Adds release announcement to github workflows Feb 7, 2024
oliviertassinari
oliviertassinari reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I guess we don't use https://github.com/marketplace/actions/github-releases-to-discord to have the highlight extract.

.github/workflows/discord-release-announcement.yaml Show resolved Hide resolved
.github/workflows/discord-release-announcement.yaml Outdated Show resolved Hide resolved
.github/workflows/discord-release-announcement.yaml Show resolved Hide resolved
@michelengelen
Copy link
Member Author

Nice 👍

I guess we don't use https://github.com/marketplace/actions/github-releases-to-discord to have the highlight extract.

No, we don't, since every action available was either not working or did not have the feature set we wanted.

danilo-leal
danilo-leal reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Can this be extended to the Core side of the world, too? If yes, a follow up question would be if it is possible to cherry pick which announcements go to Discord?

@oliviertassinari oliviertassinari changed the title [code-infra] Adds release announcement to github workflows [infra] Add release announcement to github workflows Feb 21, 2024
@oliviertassinari oliviertassinari changed the title [infra] Add release announcement to github workflows [infra] Add release announcement to GitHub workflows Feb 21, 2024
@oliviertassinari oliviertassinari added scope: infra Org infrastructure work going on behind the scenes and removed scope: code-infra Specific to the core-infra product labels Feb 21, 2024
@michelengelen @oliviertassinari
Update scripts/releaseChangelog.mjs
c843c7f 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@michelengelen
Merge branch 'next' into automation/discord-release-announcement
aca244c 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 3, 2024
@michelengelen
Copy link
Member Author

Can we move on with this PR or are there any change requests from either of you?
@DanailH @joserodolfofreitas @oliviertassinari

@michelengelen michelengelen changed the title [infra] Add release announcement to GitHub workflows [support-infra] Add release announcement to GitHub workflows Apr 3, 2024
@michelengelen michelengelen merged commit 3f18594 into mui:next Apr 3, 2024
17 checks passed
@michelengelen michelengelen deleted the automation/discord-release-announcement branch April 3, 2024 13:34
@michelengelen michelengelen added the needs cherry-pick The PR should be cherry-picked to master after merge label Apr 19, 2024
michelengelen added a commit to michelengelen/mui-x that referenced this pull request Apr 19, 2024
@michelengelen @oliviertassinari
[support-infra] Add release announcement to GitHub workflows (mui#11867)
9014774 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
michelengelen added a commit that referenced this pull request Apr 19, 2024
@michelengelen @oliviertassinari
[support-infra] Add release announcement to GitHub workflows (#11867) (…
fb8f3da 
…#12843)

Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
@LukasTy LukasTy mentioned this pull request Jun 5, 2024
Merged
1 task
rafael-lopes-rlabs pushed a commit to rafael-lopes-rlabs/mui-x that referenced this pull request Aug 1, 2024
@michelengelen @oliviertassinari @rafael-lopes-rlabs
[support-infra] Add release announcement to GitHub workflows (mui#11867)
f09f83a 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@michelengelen @oliviertassinari @thomasmoon
[support-infra] Add release announcement to GitHub workflows (mui#11867…
75502c2 
…) (mui#12843)

Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal left review comments

@DanailH DanailH DanailH approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

Assignees

@michelengelen michelengelen

Labels
core Infrastructure work going on behind the scenes needs cherry-pick The PR should be cherry-picked to master after merge scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michelengelen @mui-bot @joserodolfofreitas @oliviertassinari @DanailH @danilo-leal