[data grid] Fixed issue where pressing Delete key resets various cell values to empty string. #12216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opriately, ensuring data integrity.
… column type, ensuring data integrity.
sooster910
changed the title
sooster910
changed the title
|
Deploy preview: https://deploy-preview-12216--material-ui-x.netlify.app/ |
sooster910
changed the title
zannager
added
the
component: data grid
|
Hi @michelengelen Could you kindly take a moment to review the PR I submitted? 🙇♀️ Any suggestion would be appreciated! |
michelengelen
changed the title
michelengelen
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM ... thanks for picking it up!
Let's wait for the review from @romgrk though!
Thanks a lot!! |
romgrk
approved these changes
Mar 13, 2024
1 task
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
… values to empty string. (mui#12216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12125 michelengelen
This PR refines the value reset logic to align with column data types on Backspace/Delete key press.
UnitTesting
Implemented tests to check cell value reset upon Backspace and Delete key presses.
The video shows the correct default boolean value when the delete/backspace key is pressed.