[DataGrid] Avoid re-rendering all cells on column change #12980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
performance
component: data grid
|
Deploy preview: https://deploy-preview-12980--material-ui-x.netlify.app/ |
MBilalShafi
approved these changes
May 4, 2024
packages/x-data-grid/src/hooks/features/columns/gridColumnsUtils.ts
Outdated
Show resolved
Hide resolved
romgrk
commented
May 7, 2024
packages/x-data-grid/src/components/columnHeaders/GridGenericColumnHeaderItem.tsx
Show resolved
Hide resolved
romgrk
commented
May 7, 2024
cherniavskii
reviewed
May 9, 2024
packages/x-data-grid/src/components/columnHeaders/GridColumnHeaderItem.tsx
Outdated
Show resolved
Hide resolved
romgrk
force-pushed
the
perf-avoid-render-cells-column-change
branch
2 times, most recently
from
52b949c to
3d49cb9
Compare
cherniavskii
approved these changes
May 24, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12952
This change prevents all columns from re-rendering when one column is changed.
Before: https://codesandbox.io/p/sandbox/friendly-montalcini-yfkfvd
After: https://codesandbox.io/p/sandbox/black-brook-jr7r3d?file=%2Fsrc%2FApp.tsx