[DataGridPremium] Fix excel export causing column with wrong width #13191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
component: data grid
|
Deploy preview: https://deploy-preview-13191--material-ui-x.netlify.app/ |
romgrk
commented
May 20, 2024
| createValueOptionsSheetIfNeeded(valueOptionsData, valueOptionsSheetName, workbook); | ||
|
|
||
| rowIds.forEach((id) => { | ||
| const serializedRow = serializeRow(id, columns, api, valueOptionsData, options); | ||
| const serializedRow = serializeRow(id, columns, apiRef, valueOptionsData, options); |
There was a problem hiding this comment.
Confirm if this can also mutate the colspan info.
| @@ -85,7 +85,7 @@ const createScrollCache = ( | |||
| }); | |||
| type ScrollCache = ReturnType<typeof createScrollCache>; | |||
|
|
|||
| const isJSDOM = typeof window !== 'undefined' ? /jsdom/.test(window.navigator.userAgent) : false; | |||
| const isJSDOM = typeof navigator !== 'undefined' ? /jsdom/.test(navigator.userAgent) : false; | |||
There was a problem hiding this comment.
This change caused the tests in JSDOM to fail.
Turns out navigator.userAgent !== window.navigator.userAgent:
I'll submit a PR to the core repo to fix this inconsistency.
What was the reason for this change anyway? We should revert it for now
There was a problem hiding this comment.
It was failing in devmode inside an excel export worker, something being undefined.
There was a problem hiding this comment.
Not inside a worker but I have no idea why this happens in devmode. I've wrapped in a try.
cherniavskii
approved these changes
May 23, 2024
packages/x-data-grid-premium/src/hooks/features/export/serializer/excelSerializer.ts
Show resolved
Hide resolved
MBilalShafi
approved these changes
May 24, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12641
Before: https://codesandbox.io/p/sandbox/silly-pare-vfzsdq (this fails in CSB, not sure if excel export is testable there?)
After: