[docs-infra] Fix @mui/material version used in sandboxes
#13260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
commented
May 27, 2024
| // #default-branch-switch | ||
| // Check which version of `@mui/material` should be resolved when opening docs examples in StackBlitz or CodeSandbox | ||
| newDeps['@mui/material'] = | ||
| versions['@mui/material'] !== 'next' ? versions['@mui/material'] : 'latest'; |
There was a problem hiding this comment.
I've gone with a solution, which still allows monorepo to provide a specific @mui/material version, but if you think that we should just go for simplicity—we can do that. 👌
-versions['@mui/material'] !== 'next' ? versions['@mui/material'] : 'latest';
+'latest';
|
Deploy preview: https://deploy-preview-13260--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
May 27, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @mui/monorepo we get
nextas the resolved version to be used in sandboxes, which is perfectly valid for them.But
@mui/xpackages support only v5 releases of@mui/material.This ensures consistency between docs demos and the opened sandbox examples (StackBlitz or CodeSandbox).
Before
After