-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Move @mui/internal-test-utils
to dev dependency
#13318
Conversation
Deploy preview: https://deploy-preview-13318--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
I think the plan is to have internal packages always on canary versions in dependent repositories. I'm under the assumption the intention is: latest: 1.0.0 - published while public packages are published. We don't use this verison in X/Toolpad/base So, I think the cc @michaldudak |
Ok, gotcha, if that's the intent, we can adjust the approach. 👌 |
I suppose we can configure renovatebot to follow a specific tag, but since this is an internal package we can probably leave it as is |
Fixes #13317.
@mui/internal-test-utils
dependency fromdependencies
todevDependencies
on the@mui/x-data-grid
package.1.0.0
.WDYT @mui/code-infra, wouldn't it be more correct if the internal package stable versions were released with the
latest
flag instead ofnext
? 🤔