Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix the description of tickInterval #13355

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

alexfauquette
Copy link
Member

From docs feedback

It is not clear when tickInterval is used and when is not. I placed breakpoint in useTicks.js to see how ticks are calculated for my BarChart, and useTicks returned result without using tickInterval value at all, doesn't matter if it is array or filtering function (code bellow comment //scale type = 'band').

BtW this feature is not applied on bar chart. The reason why is very opinionated. bar chart should be used on categorical plotting. So each tick should be present. But it's something open to dicussion

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Jun 3, 2024
@alexfauquette alexfauquette requested a review from JCQuintas June 3, 2024 07:47
@mui-bot
Copy link

mui-bot commented Jun 3, 2024

Deploy preview: https://deploy-preview-13355--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 44024cd

Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something open to dicussion

While it is current behaviour right now, it will eventually need changes, as #12537 would introduce "non-band" series types to bars. The current concept might be too limited

@alexfauquette
Copy link
Member Author

it will eventually need changes, as #12537 would introduce "non-band" series types

I still have no clear idea about how we can fix this issue. If you have ideas about how the DX should look like to support it, I would be interested to read it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants