Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Improve TypeScript for plugins #13380

Merged
merged 9 commits into from
Jun 10, 2024
Merged

[TreeView] Improve TypeScript for plugins #13380

merged 9 commits into from
Jun 10, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 5, 2024 •
edited
Loading

Cleaner version of #13311 without the changes outside of TypeScript

  • Clean the generic names (TSignatures for signatures, TPlugins for plugins)
  • Always use signatures as generic, no more mix of signatures and plugins depending on the hook / method / interface
  • Clean the injection of core plugins in the apiRef and instance

@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jun 5, 2024
@flaviendelangle flaviendelangle self-assigned this Jun 5, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] Improve TypeScript for plugins [TreeView] Improve TypeScript for plugins [WIP] Jun 5, 2024
@mui-bot
Copy link

mui-bot commented Jun 5, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13380--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 6a8e501

@flaviendelangle flaviendelangle changed the title [TreeView] Improve TypeScript for plugins [WIP] [TreeView] Improve TypeScript for plugins Jun 6, 2024
@flaviendelangle flaviendelangle marked this pull request as ready for review June 6, 2024 10:58
michelengelen
michelengelen approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great ... :shipit:

packages/x-tree-view/src/internals/models/helpers.ts Show resolved Hide resolved
@flaviendelangle flaviendelangle merged commit 2305117 into mui:master Jun 10, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the typing-signatures branch June 10, 2024 07:35
This was referenced Jul 12, 2024
Merged
Merged
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @DungTiger
[TreeView] Improve TypeScript for plugins (mui#13380)
a60647d
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @thomasmoon
[TreeView] Improve TypeScript for plugins (mui#13380)
387bb5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @michelengelen