-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add eslint-plugin-react-compiler
experimental version and rules
#13415
[core] Add eslint-plugin-react-compiler
experimental version and rules
#13415
Conversation
Deploy preview: https://deploy-preview-13415--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a small comment.
Apart from that, beware of the problem I just stumbled upon: we can't use eslint-disable
for rules that are not set up. See: mui/material-ui#42566 (comment)
edit: maybe we should always include the plugin but turn the rules off. I'll see if that works.
edit 2: it didn't work 😢
@JCQuintas I finally went with the approach of commenting out the |
We didnt start acting on these issues yet, will keep that in mind. Thanks 👍 |
Added multiple ways to enable the eslint rule, globaly or by "package"
Part of mui/material-ui#42548