Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add eslint-plugin-react-compiler experimental version and rules #13415

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jun 7, 2024

Added multiple ways to enable the eslint rule, globaly or by "package"

ENABLE_REACT_COMPILER_PLUGIN=true pnpm eslint

// Or use one of the package specific ones

Part of mui/material-ui#42548

@JCQuintas JCQuintas added core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes labels Jun 7, 2024
@JCQuintas JCQuintas requested a review from a team June 7, 2024 14:07
@JCQuintas JCQuintas self-assigned this Jun 7, 2024
@mui-bot
Copy link

mui-bot commented Jun 7, 2024

Deploy preview: https://deploy-preview-13415--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e9a6400

@oliviertassinari oliviertassinari added scope: code-infra Specific to the core-infra product and removed scope: infra Org infrastructure work going on behind the scenes labels Jun 7, 2024
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a small comment.

Apart from that, beware of the problem I just stumbled upon: we can't use eslint-disable for rules that are not set up. See: mui/material-ui#42566 (comment)

edit: maybe we should always include the plugin but turn the rules off. I'll see if that works.

edit 2: it didn't work 😢

.eslintrc.js Outdated Show resolved Hide resolved
@JCQuintas JCQuintas merged commit 8e935d6 into mui:master Jun 10, 2024
17 checks passed
@JCQuintas JCQuintas deleted the add-eslint-plugin-react-compiler branch June 10, 2024 09:56
@aarongarciah
Copy link
Member

@JCQuintas I finally went with the approach of commenting out the // eslint-disable-next-line react-compiler/react-compiler comments until we enable eslint-plugin-react-compiler mui/material-ui#42566 (comment)

@JCQuintas
Copy link
Member Author

@JCQuintas I finally went with the approach of commenting out the // eslint-disable-next-line react-compiler/react-compiler comments until we enable eslint-plugin-react-compiler mui/material-ui#42566 (comment)

We didnt start acting on these issues yet, will keep that in mind. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants