[DataGrid] Add getFilterState method
#13418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
|
Deploy preview: https://deploy-preview-13418--material-ui-x.netlify.app/ Updated pages: |
michelengelen
approved these changes
Jun 7, 2024
michelengelen
requested changes
Jun 10, 2024
cherniavskii
added
customization: logic
romgrk
reviewed
Jun 10, 2024
Comment on lines
+65
to
+70
| /** | ||
| * Returns the filter state for the given filter model without applying it to the data grid. | ||
| * @param {GridFilterModel} filterModel The filter model to get the state for. | ||
| * @returns {GridStateCommunity['filter']} The filter state. | ||
| */ | ||
| getFilterState: (filterModel: GridFilterModel) => GridStateCommunity['filter']; |
There was a problem hiding this comment.
This sounds like it should be a (pure) selector, but I see how that would be annoying to implement.
romgrk
approved these changes
Jun 10, 2024
MBilalShafi
approved these changes
Jun 11, 2024
|
@michelengelen I need an approval from you in order to merge it |
michelengelen
approved these changes
Jun 13, 2024
Merged
This was referenced Jul 12, 2024
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://deploy-preview-13418--material-ui-x.netlify.app/x/react-data-grid/filtering-recipes/#calculating-filtered-rows-in-advance
Fixes #13413