Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Improve themeAugmentation typing #13433

Merged
merged 2 commits into from
Jun 10, 2024
Merged

[charts] Improve themeAugmentation typing #13433

merged 2 commits into from
Jun 10, 2024

Conversation

noraleonte
Copy link
Contributor

Not sure if this interferes with anything, but noticed it when a CI failed on the dashboard.

@noraleonte noraleonte added typescript component: charts This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features labels Jun 10, 2024
@mui-bot
Copy link

mui-bot commented Jun 10, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13433--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b346dda

@LukasTy LukasTy changed the title [Charts] Improve themeAugmentation typing [charts] Improve themeAugmentation typing Jun 10, 2024
LukasTy
LukasTy reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very welcome and logical improvement. 👍

I think that you might have missed the Theme declaration on module declaration, i.e.:

mui-x/packages/x-date-pickers/src/themeAugmentation/components.d.ts

Line 199 in 40e631d

interface Components<Theme = unknown> extends PickerComponents<Theme> {}

@noraleonte
Copy link
Contributor Author

@LukasTy Thanks 🎉 Hawk's eye as always 😅

@noraleonte noraleonte merged commit ece9ce0 into mui:master Jun 10, 2024
17 checks passed
@noraleonte noraleonte deleted the theme-augmentation-typing branch June 10, 2024 12:19
@michelengelen michelengelen changed the title [charts] Improve themeAugmentation typing [charts] Improve themeAugmentation typing Jun 10, 2024
This was referenced Jul 12, 2024
Merged
Merged
Open
Open
@alhabib5565 alhabib5565 mentioned this pull request Jul 14, 2024
Open
@KotoneZQ KotoneZQ mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 20, 2024
Open
Open
@Carment14tham Carment14tham mentioned this pull request Jul 20, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@noraleonte @DungTiger
[charts] Improve themeAugmentation typing (mui#13433)
3dfd456
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@noraleonte @thomasmoon
[charts] Improve themeAugmentation typing (mui#13433)
0ae1e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@JCQuintas JCQuintas Awaiting requested review from JCQuintas

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees
No one assigned
Labels
component: charts This is the name of the generic UI component, not the React module! customization: theme Centered around the theming features typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noraleonte @mui-bot @flaviendelangle @LukasTy