[infra] Adjust CI setup #13448
Merged
[infra] Adjust CI setup #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
core
|
Deploy preview: https://deploy-preview-13448--material-ui-x.netlify.app/ |
Janpot
reviewed
Jun 11, 2024
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Lukas <llukas.tyla@gmail.com>
This was referenced Jul 12, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Lukas <llukas.tyla@gmail.com> Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dangerstep as the playwright does not seem to need it... 🤷 🙈pnpmversion as inpackage.jsonlatest-8is no longer correct as we already use v9latest-9is potentially incorrect depending on which version is specified inpackage.json.Do you know if omitting the@portion would end up using thepackage.jsonspecifier? @Janpot @michaldudak I see that both base-ui and toolpad do not callcorepack prepare. Have you seen any problems with it? Or maybe we could also remove it? 🤔Removed the
corepack prepareas agreed here: [infra] Adjust CI setup #13448 (review)