-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Support itemId
with escaping characters when using SimpleTreeView
#13487
Merged
flaviendelangle
merged 4 commits into
mui:master
from
oukunan:fix-itemId-with-escaping-characters-tree-item
Jun 19, 2024
Merged
[TreeView] Support itemId
with escaping characters when using SimpleTreeView
#13487
flaviendelangle
merged 4 commits into
mui:master
from
oukunan:fix-itemId-with-escaping-characters-tree-item
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
changed the title
[TreeView] fix TreeItem itemId props with escaping characters
[TreeView] Support Jun 17, 2024
itemId
with escaping characters when using SimpleTreeView
Thanks for your contribution! The fix seems good 👌 |
LukasTy
added
the
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
label
Jun 17, 2024
oukunan
force-pushed
the
fix-itemId-with-escaping-characters-tree-item
branch
from
June 17, 2024 09:41
cd23303
to
85e2d24
Compare
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
packages/x-tree-view/src/internals/TreeViewProvider/TreeViewChildrenItemProvider.tsx
Outdated
Show resolved
Hide resolved
…ildrenItemProvider.tsx Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Deploy preview: https://deploy-preview-13487--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Jun 19, 2024
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
…leTreeView` (mui#13487) Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
…leTreeView` (mui#13487) Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: tree view
TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13414