Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Support itemId with escaping characters when using SimpleTreeView #13487

Conversation

oukunan
Copy link
Contributor

@oukunan oukunan commented Jun 14, 2024

Closes #13414

@flaviendelangle flaviendelangle changed the title [TreeView] fix TreeItem itemId props with escaping characters [TreeView] Support itemId with escaping characters when using SimpleTreeView Jun 17, 2024
@flaviendelangle
Copy link
Member

Thanks for your contribution! The fix seems good 👌
🤔 No idea why the CI is failing like this
Could you please try to rebase with master?

@LukasTy LukasTy added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jun 17, 2024
@oukunan oukunan force-pushed the fix-itemId-with-escaping-characters-tree-item branch from cd23303 to 85e2d24 Compare June 17, 2024 09:41
oukunan and others added 2 commits June 17, 2024 16:44
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…ildrenItemProvider.tsx

Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@mui-bot
Copy link

mui-bot commented Jun 19, 2024

Deploy preview: https://deploy-preview-13487--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2968ad2

@flaviendelangle flaviendelangle merged commit 3c6ce8e into mui:master Jun 19, 2024
17 checks passed
@flaviendelangle flaviendelangle added the bug 🐛 Something doesn't work label Jun 19, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
…leTreeView` (mui#13487)

Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
…leTreeView` (mui#13487)

Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] Can't use itemId with escaping characters in SimpleTreeView
4 participants