[DataGrid] Fix SSR support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
I have tested the change manually, we are good, I'm merging to unlock #115. |
dtassone
reviewed
Aug 3, 2020
| export function useLoggerFactory( | ||
| customLogger?: Logger | LoggerFactoryFn, | ||
| logLevel: string | boolean = 'debug', | ||
| logLevel: string = 'debug', |
There was a problem hiding this comment.
the boolean was to turn off logging
There was a problem hiding this comment.
You are right. I have restored it in a follow up pull request. If you check master it should be back in here. It was creating TypeScript errors in the demos/stories but wasn't catch by the CI.
The CI part is now covered by building in Netlify the current commit, it's not ideal but it's a good first safeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #98.
I didn't test the changes, I would need #115 for doing such but I hope it's good enough, finger crossed.
This is important so we can document the data grid components.