Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Add expansionTrigger prop #13533

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

noraleonte
Copy link
Contributor

extracted from #13388

By default, the expansion of a tree item is triggered if the content is clicked. This PR introduces a prop to allow users to override this behavior, and limit the expansion to iconContainer

@noraleonte noraleonte added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jun 18, 2024
@noraleonte noraleonte self-assigned this Jun 18, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2024
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpick on the doc, the behavior looks great!
Thanks for taking care of it 🥳

docs/data/tree-view/rich-tree-view/expansion/expansion.md Outdated Show resolved Hide resolved
docs/data/tree-view/rich-tree-view/expansion/expansion.md Outdated Show resolved Hide resolved
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
@noraleonte noraleonte merged commit 0ea1d15 into mui:master Jun 25, 2024
17 checks passed
@noraleonte noraleonte deleted the add-expansiontrigger-prop branch June 25, 2024 14:44
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants