Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Add columnHeaderSortIcon slot #13563

Merged
merged 4 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/pages/x/api/data-grid/data-grid-premium.json
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,12 @@
"default": "GridColumnHeaderFilterIconButton",
"class": null
},
{
"name": "columnHeaderSortIcon",
"description": "Sort icon component rendered in each column header.",
"default": "GridColumnHeaderSortIcon",
"class": null
},
{
"name": "columnMenu",
"description": "Column menu component rendered by clicking on the 3 dots \"kebab\" icon in column headers.",
Expand Down
6 changes: 6 additions & 0 deletions docs/pages/x/api/data-grid/data-grid-pro.json
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,12 @@
"default": "GridColumnHeaderFilterIconButton",
"class": null
},
{
"name": "columnHeaderSortIcon",
"description": "Sort icon component rendered in each column header.",
"default": "GridColumnHeaderSortIcon",
"class": null
},
{
"name": "columnMenu",
"description": "Column menu component rendered by clicking on the 3 dots \"kebab\" icon in column headers.",
Expand Down
6 changes: 6 additions & 0 deletions docs/pages/x/api/data-grid/data-grid.json
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,12 @@
"default": "GridColumnHeaderFilterIconButton",
"class": null
},
{
"name": "columnHeaderSortIcon",
"description": "Sort icon component rendered in each column header.",
"default": "GridColumnHeaderSortIcon",
"class": null
},
{
"name": "columnMenu",
"description": "Column menu component rendered by clicking on the 3 dots \"kebab\" icon in column headers.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,7 @@
"columnFilteredIcon": "Icon displayed on the column header menu to show that a filter has been applied to the column.",
"columnHeaderFilterIconButton": "Filter icon component rendered in each column header.",
"columnHeaders": "Component responsible for rendering the column headers.",
"columnHeaderSortIcon": "Sort icon component rendered in each column header.",
"columnMenu": "Column menu component rendered by clicking on the 3 dots "kebab" icon in column headers.",
"columnMenuAggregationIcon": "Icon displayed in column menu for aggregation",
"columnMenuClearIcon": "Icon displayed in column menu for clearing values",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,7 @@
"columnFilteredIcon": "Icon displayed on the column header menu to show that a filter has been applied to the column.",
"columnHeaderFilterIconButton": "Filter icon component rendered in each column header.",
"columnHeaders": "Component responsible for rendering the column headers.",
"columnHeaderSortIcon": "Sort icon component rendered in each column header.",
"columnMenu": "Column menu component rendered by clicking on the 3 dots "kebab" icon in column headers.",
"columnMenuClearIcon": "Icon displayed in column menu for clearing values",
"columnMenuFilterIcon": "Icon displayed in column menu for filter",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,7 @@
"columnFilteredIcon": "Icon displayed on the column header menu to show that a filter has been applied to the column.",
"columnHeaderFilterIconButton": "Filter icon component rendered in each column header.",
"columnHeaders": "Component responsible for rendering the column headers.",
"columnHeaderSortIcon": "Sort icon component rendered in each column header.",
"columnMenu": "Column menu component rendered by clicking on the 3 dots "kebab" icon in column headers.",
"columnMenuClearIcon": "Icon displayed in column menu for clearing values",
"columnMenuFilterIcon": "Icon displayed in column menu for filter",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { fastMemo } from '../../utils/fastMemo';
import { GridStateColDef } from '../../models/colDef/gridColDef';
import { GridSortDirection } from '../../models/gridSortModel';
import { useGridPrivateApiContext } from '../../hooks/utils/useGridPrivateApiContext';
import { GridColumnHeaderSortIcon } from './GridColumnHeaderSortIcon';
import { GridColumnHeaderSeparatorProps } from './GridColumnHeaderSeparator';
import { ColumnHeaderMenuIcon } from './ColumnHeaderMenuIcon';
import { GridColumnHeaderMenu } from '../menu/columnMenu/GridColumnHeaderMenu';
Expand Down Expand Up @@ -248,11 +247,13 @@ function GridColumnHeaderItem(props: GridColumnHeaderItemProps) {
)}

{showSortIcon && (
<GridColumnHeaderSortIcon
<rootProps.slots.columnHeaderSortIcon
field={colDef.field}
direction={sortDirection}
index={sortIndex}
sortingOrder={sortingOrder}
disabled={!colDef.sortable}
{...rootProps.slotProps?.columnHeaderSortIcon}
/>
)}
</React.Fragment>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { DataGridProcessedProps } from '../../models/props/DataGridProps';
import { GridIconButtonContainer } from './GridIconButtonContainer';

export interface GridColumnHeaderSortIconProps {
field: string;
direction: GridSortDirection;
index: number | undefined;
sortingOrder: readonly GridSortDirection[];
Expand Down Expand Up @@ -51,7 +52,7 @@ function getIcon(
}

function GridColumnHeaderSortIconRaw(props: GridColumnHeaderSortIconProps) {
const { direction, index, sortingOrder, disabled } = props;
const { direction, index, sortingOrder, disabled, ...other } = props;
const apiRef = useGridApiContext();
const rootProps = useGridRootProps();
const ownerState = { ...props, classes: rootProps.classes };
Expand All @@ -70,6 +71,7 @@ function GridColumnHeaderSortIconRaw(props: GridColumnHeaderSortIconProps) {
size="small"
disabled={disabled}
{...rootProps.slotProps?.baseIconButton}
{...other}
>
{iconElement}
</rootProps.slots.baseIconButton>
Expand Down Expand Up @@ -97,6 +99,7 @@ GridColumnHeaderSortIconRaw.propTypes = {
// ----------------------------------------------------------------------
direction: PropTypes.oneOf(['asc', 'desc']),
disabled: PropTypes.bool,
field: PropTypes.string.isRequired,
index: PropTypes.number,
sortingOrder: PropTypes.arrayOf(PropTypes.oneOf(['asc', 'desc'])).isRequired,
} as any;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
GridColumnHeaderFilterIconButton,
GridRowCount,
GridColumnsManagement,
GridColumnHeaderSortIcon,
} from '../components';
import { GridCell } from '../components/cell/GridCell';
import { GridColumnHeaders } from '../components/GridColumnHeaders';
Expand All @@ -28,6 +29,7 @@ export const DATA_GRID_DEFAULT_SLOTS_COMPONENTS: GridSlotsComponent = {
cell: GridCell,
skeletonCell: GridSkeletonCell,
columnHeaderFilterIconButton: GridColumnHeaderFilterIconButton,
columnHeaderSortIcon: GridColumnHeaderSortIcon,
columnMenu: GridColumnMenu,
columnHeaders: GridColumnHeaders,
detailPanels: GridDetailPanels,
Expand Down
5 changes: 5 additions & 0 deletions packages/x-data-grid/src/models/gridSlotsComponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ export interface GridSlotsComponent extends GridBaseSlots, GridIconSlotsComponen
columnHeaderFilterIconButton: React.JSXElementConstructor<
GridSlotProps['columnHeaderFilterIconButton']
>;
/**
* Sort icon component rendered in each column header.
* @default GridColumnHeaderSortIcon
*/
columnHeaderSortIcon: React.JSXElementConstructor<GridSlotProps['columnHeaderSortIcon']>;
/**
* Column menu component rendered by clicking on the 3 dots "kebab" icon in column headers.
* @default GridColumnMenu
Expand Down
5 changes: 4 additions & 1 deletion packages/x-data-grid/src/models/gridSlotsComponentsProps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import type { GridColumnHeadersProps } from '../components/GridColumnHeaders';
import type { GridDetailPanelsProps } from '../components/GridDetailPanels';
import type { GridPinnedRowsProps } from '../components/GridPinnedRows';
import type { GridColumnsManagementProps } from '../components/columnsManagement/GridColumnsManagement';
import type { GridRowCountProps } from '../components';
import type { GridRowCountProps } from '../components/GridRowCount';
import type { GridColumnHeaderSortIconProps } from '../components/columnHeaders/GridColumnHeaderSortIcon';

// Overrides for module augmentation
export interface BaseCheckboxPropsOverrides {}
Expand All @@ -46,6 +47,7 @@ export interface BaseChipPropsOverrides {}
export interface CellPropsOverrides {}
export interface ToolbarPropsOverrides {}
export interface ColumnHeaderFilterIconButtonPropsOverrides {}
export interface ColumnHeaderSortIconPropsOverrides {}
export interface ColumnMenuPropsOverrides {}
export interface ColumnsPanelPropsOverrides {}
export interface DetailPanelsPropsOverrides {}
Expand Down Expand Up @@ -84,6 +86,7 @@ export interface GridSlotProps {
columnHeaders: GridColumnHeadersProps;
columnHeaderFilterIconButton: ColumnHeaderFilterIconButtonProps &
ColumnHeaderFilterIconButtonPropsOverrides;
columnHeaderSortIcon: GridColumnHeaderSortIconProps & ColumnHeaderSortIconPropsOverrides;
columnMenu: GridColumnMenuProps & ColumnMenuPropsOverrides;
columnsPanel: GridColumnsPanelProps & ColumnsPanelPropsOverrides;
columnsManagement: GridColumnsManagementProps & ColumnsManagementPropsOverrides;
Expand Down
1 change: 1 addition & 0 deletions scripts/x-data-grid-premium.exports.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
{ "name": "checkGridRowIdIsValid", "kind": "Function" },
{ "name": "ColumnHeaderFilterIconButtonProps", "kind": "Interface" },
{ "name": "ColumnHeaderFilterIconButtonPropsOverrides", "kind": "Interface" },
{ "name": "ColumnHeaderSortIconPropsOverrides", "kind": "Interface" },
{ "name": "ColumnMenuPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsManagementPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsPanelPropsOverrides", "kind": "Interface" },
Expand Down
1 change: 1 addition & 0 deletions scripts/x-data-grid-pro.exports.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
{ "name": "checkGridRowIdIsValid", "kind": "Function" },
{ "name": "ColumnHeaderFilterIconButtonProps", "kind": "Interface" },
{ "name": "ColumnHeaderFilterIconButtonPropsOverrides", "kind": "Interface" },
{ "name": "ColumnHeaderSortIconPropsOverrides", "kind": "Interface" },
{ "name": "ColumnMenuPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsManagementPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsPanelPropsOverrides", "kind": "Interface" },
Expand Down
1 change: 1 addition & 0 deletions scripts/x-data-grid.exports.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
{ "name": "checkGridRowIdIsValid", "kind": "Function" },
{ "name": "ColumnHeaderFilterIconButtonProps", "kind": "Interface" },
{ "name": "ColumnHeaderFilterIconButtonPropsOverrides", "kind": "Interface" },
{ "name": "ColumnHeaderSortIconPropsOverrides", "kind": "Interface" },
{ "name": "ColumnMenuPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsManagementPropsOverrides", "kind": "Interface" },
{ "name": "ColumnsPanelPropsOverrides", "kind": "Interface" },
Expand Down
Loading