-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Remove "-" in heat-map and tree-map urls #13569
Conversation
Deploy preview: https://deploy-preview-13569--material-ui-x.netlify.app/ Updated pages: |
Maybe we should update: mui-x/docs/scripts/reportBrokenLinks.js Line 48 in d7abca3
to be: const usedLinks = usedLinksX; I'm not sure that checking links across Base UI, Material UI, and Joy UI repositories in the future will scale well (e.g. this PR whose build is failing because we need mui/material-ui#42697). But it's indeed nice that this works today. |
The impact on other PR is more my fault than the script. You can bypass the test by running it locally and saving the updated file. About this specific PR: I merged a PR with the test broken because I remembered I can bypass it, but obviously it was not the correct way to do it About linking to base, joy, material, and the blog. The main reason was the rewording effort of Sam. Because titles impact the anchor link, and so our link anchor to the core got broken frequently |
Fair enough, this works as well.
I see, even ahrefs doesn't report them. Don't hesitate to upvote https://ahrefs.canny.io/site-audit/p/find-broken-html-anchor-link 😁 |
Since we plan to call those components Heatmap and Treemap having a "-" in the url makes no sense. So I propose to fix h=this before releasing one of those components