[DataGrid] Fix dimensions lag issue after autosize #13587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
|
Deploy preview: https://deploy-preview-13587--material-ui-x.netlify.app/ |
MBilalShafi
changed the title
MBilalShafi
commented
Jun 24, 2024
packages/x-data-grid/src/hooks/features/dimensions/useGridDimensions.ts
Outdated
Show resolved
Hide resolved
romgrk
approved these changes
Jun 25, 2024
| @@ -302,26 +303,25 @@ export function useGridDimensions( | |||
| }, [apiRef, savedSize, updateDimensions]); | |||
|
|
|||
| const root = apiRef.current.rootElementRef.current; | |||
| const dimensions = apiRef.current.state.dimensions; | |||
There was a problem hiding this comment.
I'd be curious to know why the material-ui/no-direct-state-access linting rule did not catch it 🤔
There was a problem hiding this comment.
I was under the impression this rule is not activated, as there are multiple instances where we do direct state access around the code base. Should it detect all the instances? 🤔
There was a problem hiding this comment.
I don't know, Matheus created it I think, since it's a rule that is mostly here for us, if it does not work maybe we can fix it or drop it 😆
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12940