Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix custom "no results overlay" demo in dark mode #13715

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

KenanYusuf
Copy link
Member

Remove unwanted backticks from demo CSS - was causing the icon not to display in demo.

Before

Screenshot 2024-07-03 at 11 40 19

After

Screenshot 2024-07-03 at 11 40 07

@KenanYusuf KenanYusuf added the docs Improvements or additions to the documentation label Jul 3, 2024
@KenanYusuf KenanYusuf requested a review from MBilalShafi July 3, 2024 10:43
@mui-bot
Copy link

mui-bot commented Jul 3, 2024

Deploy preview: https://deploy-preview-13715--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a5f4b62

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KenanYusuf KenanYusuf merged commit c12523e into mui:master Jul 3, 2024
17 checks passed
@KenanYusuf KenanYusuf deleted the fix-no-results-overlay-dark-demo branch July 3, 2024 11:20
@cherniavskii cherniavskii changed the title [docs] fix custom "no results overlay" demo in dark mode [docs] Fix custom "no results overlay" demo in dark mode Jul 9, 2024
@cherniavskii cherniavskii added the component: data grid This is the name of the generic UI component, not the React module! label Jul 9, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants