Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Pickers customization playground overflow #13742

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 5, 2024

Fixes #13736.

Also add DateTimeRangePicker into this playground.

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Jul 5, 2024
@LukasTy LukasTy self-assigned this Jul 5, 2024
@mui-bot
Copy link

mui-bot commented Jul 5, 2024

Deploy preview: https://deploy-preview-13742--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b0d1c14

@@ -392,6 +396,7 @@ export default function PickersPlayground() {
ampm: ampm !== undefined ? ampm : undefined,
ampmInClock: ampmInClock !== undefined ? ampmInClock : undefined,
displayStaticWrapperAs: isStaticDesktopMode ? 'desktop' : 'mobile',
sx: { [`&.${pickersLayoutClasses.root}`]: { overflowX: 'auto' } },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only relevant bugfix.

@TheOneTheOnlyJJ
Copy link

For some reason the new DateTimeRangePicker does not show at all when selected:
image

@LukasTy
Copy link
Member Author

LukasTy commented Jul 5, 2024

For some reason the new DateTimeRangePicker does not show at all when selected

It does. The Desktop and Mobile variants are rendered.
It's only the Static that is not present, because we did not create this version. at least initially. 🤔

Copy link
Member

@arthurbalduini arthurbalduini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement ! 🙂

@LukasTy LukasTy merged commit 5a1dfa1 into mui:master Jul 8, 2024
19 checks passed
@LukasTy LukasTy deleted the fix-customization-playground branch July 8, 2024 12:37
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Date Range Customization Playground does not fit on smaller screens
4 participants