Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPremium] Server-side data source with row grouping #13826
[DataGridPremium] Server-side data source with row grouping #13826
Changes from 41 commits
ac19bcd
b83928f
222da23
d8b762b
26ed96e
bb06da1
ad92678
02d1ab3
342594a
435ecdf
5d4220d
58daf43
d1712de
66ab0c8
f072523
7580c46
3780ddd
c92106d
43c6e16
0160a0a
4e832b3
5f6f0c6
779b29d
b1a955c
7dd206d
d3aad07
ed631de
17f9f33
966718e
e1f7a6a
900e127
74ff1de
c9fec5a
5303c54
509d264
0744856
5f929f1
8c623d0
c60b757
6ee149a
ba0ab94
d685bb4
7491df5
d849c38
1b5bd36
10747b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why it is not compatible? Could it call the data source to apply the behavior or is there a strong feasibility blocker?
(Question applies to both get and set methods)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data source changes a bit how expansion works.
When the user expands a row,
fetchRows
is called, which fetches the rows internally and only on success it callssetRowChildrenExpansion
internally which only updates theisExpanded
state of the respectiverowNode
.If the user tries to call
setRowChildrenExpansion
there will be no rows to show, only the expand icon will shift to expanded form, thussetRowChildrenExpansion
is no longer recommended to use with the data source.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @joserodolfofreitas
@MBilalShafi Couldn't we potentially update
setRowChildrenExpansion
to fetch rows if the data source is being used?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the conversation here.
Should we create an issue to make these approaches compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cherniavskii We certainly could. Mostly a DX decision. It hasn't been done in the current implementation because
setRowChildrenExpansion
sounds like (or anticipated as) a state setter (or a pure function), hiding thefetch
part behind would be less aligned with a user's expectation as it will now have 3 possible outcomes.Using it from within
fetchRows
makes sense if it's understood to be only responsible for1
, or we may have to change its current perception.What do you think?